From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1046DC77B73 for ; Thu, 27 Apr 2023 12:22:52 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ps0dz-0002b7-Hm; Thu, 27 Apr 2023 08:22:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ps0dx-0002ak-T0 for qemu-devel@nongnu.org; Thu, 27 Apr 2023 08:22:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ps0dv-0005pR-Ow for qemu-devel@nongnu.org; Thu, 27 Apr 2023 08:22:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682598154; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X0xlxrk99adJ/WYLvzUjWFNQG3BPi2bcTMZNjU6UNr4=; b=O1P1CWCSffE8R4L0z4m0MbzGJZYHiDB9JCsxUoNwahI774bOxRR4GTyQLB//PN7Gq2B9nZ ySkCAICmx07KaGy9JsMQaIsQ1i/TbEkDduIwz+BV1Tjs0Qb3PNrCh9lrL2vM2Yl8/iDacA v6TVWzz3gv/3muARxi6GG9I08n+o3Ls= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-172-LpBY56qqMqCX3g5PMKOMuA-1; Thu, 27 Apr 2023 08:22:31 -0400 X-MC-Unique: LpBY56qqMqCX3g5PMKOMuA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 08BC02806049; Thu, 27 Apr 2023 12:22:31 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5C47F1121314; Thu, 27 Apr 2023 12:22:29 +0000 (UTC) Date: Thu, 27 Apr 2023 13:22:26 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Cc: Paolo Bonzini , qemu-devel@nongnu.org, Eduardo Habkost , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Marcel Apfelbaum , Yanan Wang Subject: Re: [RFC PATCH 0/3] Deprecate the qemu-system-i386 binary Message-ID: References: <20230425133851.489283-1-thuth@redhat.com> <5fc11d22-275d-cc8d-bf9c-f1c015cbee23@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.171, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Apr 27, 2023 at 02:12:59PM +0200, Thomas Huth wrote: > On 27/04/2023 10.33, Daniel P. Berrangé wrote: > > On Thu, Apr 27, 2023 at 10:31:00AM +0200, Paolo Bonzini wrote: > > > On Thu, Apr 27, 2023 at 10:28 AM Daniel P. Berrangé wrote: > > > > > I wonder if we should take this a step further and rename qemu-system-x86_64 > > > > > to qemu-system-x86! Distros can if they wish create symlinks to both > > > > > qemu-system-i386 and qemu-system-x86_64. > > > > > > > > I can't help feeling this just creates a new upgrade burden for distros > > > > for no obvious win. > > > > > > We can create the symlinks on install as well during the deprecation > > > period. It doesn't have to be done by distros. > > > > What's the actual win though ? Why would anyone want to create guests > > using qemu-system-x86, if both qemu-system-i386 / qemu-system-x86_64 > > still exist indefinitely for backwards compat. > > We could deprecate the old wrappers at one point in time, so we would > finally have a cleaner interface. At the cost of breaking compat every single script and doc that referrs to the historical binaries. I think incompatible changes are worth it, but only if we associate them with the a approach to qemu system emulator binaries, as that's where we'll get a compelling benefit. Fiddling around with the existing binaries is creating pain for little gain IMHO. > > What does having a > > qemu-system-x86 add that can't be achieve just though hardlink > > between the two existing binaries ? > > We'd finally have a binary with saner default settings compared to the > backlevel "pc" machine type that we have as a default now? On the libvirt side we would have to ensure there was no change in defaults regardles of what he QEMU binary did. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|