From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBCFBC77B7F for ; Wed, 3 May 2023 17:11:38 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puG0Y-0000S8-Mm; Wed, 03 May 2023 13:11:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puG0S-0008So-MW for qemu-devel@nongnu.org; Wed, 03 May 2023 13:11:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puG0R-0006Lu-2d for qemu-devel@nongnu.org; Wed, 03 May 2023 13:11:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683133866; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BbanpH5GsPh/lAwc8DGGFG/XsQ87Kcn8fF1TEs6rdW4=; b=cQxi4OfzJF7c9FXyLFRBEW5CFjo3DLFsmwniui96bvdYlnPZlMbM6KoLxdKX5ZyXGkwMF7 hFUEuPiae3JEAGQzV21bqQsL6sZvlmVP9YJuhNb2QLVyr/OoF53RaAuar0Ma6giTjZwAW9 nMgbp7vyJCJl9OrnG798aMKpDgWcsDY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-338-xxScdtH7Nl6gRy16qcMVdg-1; Wed, 03 May 2023 13:11:02 -0400 X-MC-Unique: xxScdtH7Nl6gRy16qcMVdg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C47753C10685; Wed, 3 May 2023 17:11:01 +0000 (UTC) Received: from redhat.com (unknown [10.39.192.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 62CFDC15BAD; Wed, 3 May 2023 17:10:59 +0000 (UTC) Date: Wed, 3 May 2023 19:10:58 +0200 From: Kevin Wolf To: Juan Quintela Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Marcel Apfelbaum , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Eric Blake , Peter Xu , John Snow , Yanan Wang , Stefan Hajnoczi , Leonardo Bras , Fam Zheng , Eduardo Habkost , Vladimir Sementsov-Ogievskiy Subject: Re: [PULL 11/18] migration: Create migrate_block_bitmap_mapping() function Message-ID: References: <20230427152234.25400-1-quintela@redhat.com> <20230427152234.25400-12-quintela@redhat.com> <87jzxpqxdz.fsf@secure.mitica> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87jzxpqxdz.fsf@secure.mitica> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Received-SPF: pass client-ip=170.10.133.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.161, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Am 03.05.2023 um 16:53 hat Juan Quintela geschrieben: > Kevin Wolf wrote: > > Am 27.04.2023 um 17:22 hat Juan Quintela geschrieben: > >> Notice that we changed the test of ->has_block_bitmap_mapping > >> for the test that block_bitmap_mapping is not NULL. > >> > >> Signed-off-by: Juan Quintela > >> Reviewed-by: Vladimir Sementsov-Ogievskiy > >> > >> --- > >> > >> Make it return const (vladimir) > > > > (I don't think this part was actually meant for the commit message) > > > > This commit broke qemu-iotests 300 on master. Please have a look. > > > > Kevin > > grrr > > selfNack > > Just wondering, make check don't run this? > > I run "make check" before I sent the pull request. "make check" only runs a subset of iotests because it would take too long otherwise (especially in the context of CI - it wasn't me who made this decision). It comes at the cost that sometimes we catch problems only after merging the patch to git master when a block developer first runs the full set of tests. So I wouldn't blame your testing, it's just something that happens, and when it happens we need to look after it. Kevin