From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94121C7EE21 for ; Thu, 4 May 2023 09:41:41 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puVSQ-00069t-FF; Thu, 04 May 2023 05:41:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puVSO-00069c-Nq for qemu-devel@nongnu.org; Thu, 04 May 2023 05:41:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puVSN-0000kd-D0 for qemu-devel@nongnu.org; Thu, 04 May 2023 05:41:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683193258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MBDOQxGnFKFNch5hWnht0EvOhAiRVzRfzZweY/XOVA8=; b=JMKHZua5PmVhKW+ntJ6n/1NeChXGffoqjCRKI9Nv+0eEOdfQO2Qg+EZiZRAS1+aj02yBMR 8yVdUE4SPd8ckPMASDHq6vNvxIuZ9IyKfOHYpIU4RUajaHXRiBik3CNQtgZsRwyfRUydYA llaU2UMZHQv4c1VgSM9sz3iGJmaNBlQ= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-664-WBvB009xP5Kkviw2HVBq3Q-1; Thu, 04 May 2023 05:40:55 -0400 X-MC-Unique: WBvB009xP5Kkviw2HVBq3Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 296931C189A3; Thu, 4 May 2023 09:40:55 +0000 (UTC) Received: from redhat.com (unknown [10.39.194.84]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 865FEC15BAD; Thu, 4 May 2023 09:40:53 +0000 (UTC) Date: Thu, 4 May 2023 11:40:52 +0200 From: Kevin Wolf To: Juan Quintela Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , Peter Xu , qemu-block@nongnu.org, Leonardo Bras , Vladimir Sementsov-Ogievskiy , Fam Zheng , Eric Blake , John Snow Subject: Re: [PATCH] migration: Fix block_bitmap_mapping migration Message-ID: References: <20230503181036.14890-1-quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230503181036.14890-1-quintela@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Received-SPF: pass client-ip=170.10.133.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.161, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Am 03.05.2023 um 20:10 hat Juan Quintela geschrieben: > It is valid that params->has_block_bitmap_mapping is true and > params->block_bitmap_mapping is NULL. So we can't use the trick of > having a single function. > > Move to two functions one for each value and the tests are fixed. > > Fixes: b804b35b1c8a0edfd127ac20819c234be55ac7fc > migration: Create migrate_block_bitmap_mapping() function > > Reported-by: Kevin Wolf > Signed-off-by: Juan Quintela Thanks, applied to the block branch. Kevin