From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3EF28C77B7C for ; Thu, 4 May 2023 08:22:30 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puUDj-0006V6-FV; Thu, 04 May 2023 04:21:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puUDi-0006RN-7o for qemu-devel@nongnu.org; Thu, 04 May 2023 04:21:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puUDg-00077o-Nx for qemu-devel@nongnu.org; Thu, 04 May 2023 04:21:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683188503; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4xGfTKcWKP0HUnBN2CzpMDTYx4QAz475J9gIfA5qKzc=; b=HqbO5tNMfBUlxf1AwPFXicHiVYOtpIez9kWexuisp0CMV79ulkzCuF3L6eDMDxhAXcMXNV uwurdNSnCjb2aPpLlwFgso8V+T/HfCUyKGZjluaVjL8z+UqRmaio45Zmy81QIJkBQtvMTV mpiFgDpTLlGwUssGLvf5Gkj2QhMxw0M= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-423-qb1EzsjmNS-xcvZCQ8UjZg-1; Thu, 04 May 2023 04:21:40 -0400 X-MC-Unique: qb1EzsjmNS-xcvZCQ8UjZg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 30F7110334A3; Thu, 4 May 2023 08:21:40 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.42]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0C0D1492C3E; Thu, 4 May 2023 08:21:38 +0000 (UTC) Date: Thu, 4 May 2023 09:21:36 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, Akihiko Odaki , Paolo Bonzini , Yonggang Luo , Stefan Weil Subject: Re: [PATCH] include/qemu/osdep.h: Bump _WIN32_WINNT to the Windows 8 API Message-ID: References: <20230504081351.125140-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230504081351.125140-1-thuth@redhat.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.161, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, May 04, 2023 at 10:13:51AM +0200, Thomas Huth wrote: > Commit cf60ccc330 ("cutils: Introduce bundle mechanism") abandoned > compatibility with Windows older than 8 - we should reflect this > in our _WIN32_WINNT and set it to the value that corresponds to > Windows 8. Reference for this claim: https://learn.microsoft.com/en-us/cpp/porting/modifying-winver-and-win32-winnt?view=msvc-170 [quote] #define _WIN32_WINNT_WIN8 0x0602 // Windows 8 [/quote] > > Signed-off-by: Thomas Huth > --- > include/qemu/osdep.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé > > diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h > index 9eff0be95b..cc61b00ba9 100644 > --- a/include/qemu/osdep.h > +++ b/include/qemu/osdep.h > @@ -75,7 +75,7 @@ QEMU_EXTERN_C int daemon(int, int); > #ifdef _WIN32 > /* as defined in sdkddkver.h */ > #ifndef _WIN32_WINNT > -#define _WIN32_WINNT 0x0601 /* Windows 7 API (should be in sync with glib) */ > +#define _WIN32_WINNT 0x0602 /* Windows 8 API (should be >= the one from glib) */ > #endif > /* reduces the number of implicitly included headers */ > #ifndef WIN32_LEAN_AND_MEAN > -- > 2.31.1 > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|