qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Leonardo Bras" <leobras@redhat.com>
Subject: Re: [PATCH] migration: Rename xbzrle_enabled xbzrle_started
Date: Thu, 4 May 2023 10:17:56 -0400	[thread overview]
Message-ID: <ZFO+lJoYweoLkkPw@x1n> (raw)
In-Reply-To: <20230504115323.24407-1-quintela@redhat.com>

On Thu, May 04, 2023 at 01:53:23PM +0200, Juan Quintela wrote:
> Otherwise it is confusing with the function xbzrle_enabled().
> 
> Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  migration/ram.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/migration/ram.c b/migration/ram.c
> index 43338e1f5b..06015eeb0b 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -388,8 +388,8 @@ struct RAMState {
>      uint64_t xbzrle_pages_prev;
>      /* Amount of xbzrle encoded bytes since the beginning of the period */
>      uint64_t xbzrle_bytes_prev;
> -    /* Start using XBZRLE (e.g., after the first round). */
> -    bool xbzrle_enabled;
> +    /* Are we really  using XBZRLE (e.g., after the first round). */

double spaces

> +    bool xbzrle_started;

Reviewed-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu



  parent reply	other threads:[~2023-05-04 17:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-04 11:53 [PATCH] migration: Rename xbzrle_enabled xbzrle_started Juan Quintela
2023-05-04 12:46 ` Daniel P. Berrangé
2023-05-04 14:17 ` Peter Xu [this message]
2023-05-04 22:49   ` Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZFO+lJoYweoLkkPw@x1n \
    --to=peterx@redhat.com \
    --cc=berrange@redhat.com \
    --cc=leobras@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).