From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6424FC77B7C for ; Thu, 4 May 2023 17:43:52 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pucoC-0006so-LE; Thu, 04 May 2023 13:32:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puZvv-0005kZ-BH for qemu-devel@nongnu.org; Thu, 04 May 2023 10:27:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puZvq-0004f1-RI for qemu-devel@nongnu.org; Thu, 04 May 2023 10:27:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683210461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n1KnbsECs0MVFgN72HBootyvPzF4pVoYHdcXGTBSkcs=; b=FhIH6glTlM3SppfA7eTt4XFzewLuJIshmuE6OjL/uNGwJXPmLYBp/nokfoC7m0fg4Dy+tE 6Q4JCSNPgs8c6Vv3KUf6uO4vJQnwIGT9ymNe3XIoJTig/iPet0YCORj91PFD/ickIpTuxa Y1mvncvsFLUHwL1QcyRwFiIPmwsjcJA= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-669-Mac2pIpNMgmCLKwoN2pBGQ-1; Thu, 04 May 2023 10:27:40 -0400 X-MC-Unique: Mac2pIpNMgmCLKwoN2pBGQ-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-5ea572ef499so173406d6.1 for ; Thu, 04 May 2023 07:27:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683210459; x=1685802459; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=n1KnbsECs0MVFgN72HBootyvPzF4pVoYHdcXGTBSkcs=; b=FNXhi+cpICHcIs+xNcsV4DHv8tcqy0gGgi2EyqJrab3gB+7rLkMzvKO/TinieNh/Nl HQ4MrKg6v8yoboVEs6uxDucTwQNpMpMCCLh7CtLKXEM1aJrzcxwMXLlf+YXoF5gZXt6p GKtQu36ahBi9+nNBse386ZGvtLGPA8e10IehPRcQZrSR2zJ3NbLEdfsLN6bt+7/WriBR ksLbo6NWCQ5c0uEILvr+Uj69/4wzDtwRC084mz+f80FKICgmus/5kl7AiWIPaHzCiItd zYY3tu3XBv3NpnMWSEWp3xsQApocv8hlowHrgcZxX1eaqSoI8jJVzrEyYWK95qtTp057 GVpQ== X-Gm-Message-State: AC+VfDxTkOvjsMGXp7j0kMSo3zK9CHzloAJilBEtUmaN+GEpJEpkE6+v dtDtkkGDwFEfhNiGh+UmqvR7U1KEv6Uf9BlIGFayDrqulOIaGpoP3m7T9xA+ugZMxoBNoU/HGEH WIjTKyad5lSeGdL4= X-Received: by 2002:a05:6214:3009:b0:61b:76dd:b643 with SMTP id ke9-20020a056214300900b0061b76ddb643mr7151948qvb.4.1683210459710; Thu, 04 May 2023 07:27:39 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6r6wgN3Mm5MP04y0jh7/x9IikdnumyFUNPbnXKeNQAEdCjnN1WbfN8F4q+Zp8UnTSYk6OX4A== X-Received: by 2002:a05:6214:3009:b0:61b:76dd:b643 with SMTP id ke9-20020a056214300900b0061b76ddb643mr7151907qvb.4.1683210459438; Thu, 04 May 2023 07:27:39 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-40-70-52-229-124.dsl.bell.ca. [70.52.229.124]) by smtp.gmail.com with ESMTPSA id f2-20020ad45582000000b005fdbcab3065sm11215925qvx.72.2023.05.04.07.27.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 May 2023 07:27:38 -0700 (PDT) Date: Thu, 4 May 2023 10:27:37 -0400 From: Peter Xu To: Juan Quintela Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Stefan Hajnoczi , Leonardo Bras , Fam Zheng Subject: Re: [PATCH 6/9] qemu-file: remove shutdown member Message-ID: References: <20230504113841.23130-1-quintela@redhat.com> <20230504113841.23130-7-quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230504113841.23130-7-quintela@redhat.com> Received-SPF: pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.161, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, May 04, 2023 at 01:38:38PM +0200, Juan Quintela wrote: > The first thing that we do after setting the shutdown value is set the > error as -EIO if there is not a previous error. > > So this value is reduntant. Just remove it and use > qemu_file_get_error() in the places that it was tested. > > Signed-off-by: Juan Quintela Nit: I'd squash this with previous. Reviewed-by: Peter Xu -- Peter Xu