qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org, Leonardo Bras <leobras@redhat.com>,
	Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH 1/2] migration: Document all migration_stats
Date: Thu, 4 May 2023 17:47:22 +0100	[thread overview]
Message-ID: <ZFPhmrCnF8Rdkkxq@redhat.com> (raw)
In-Reply-To: <20230504103357.22130-2-quintela@redhat.com>

On Thu, May 04, 2023 at 12:33:56PM +0200, Juan Quintela wrote:
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  migration/migration-stats.h | 43 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
> 
> diff --git a/migration/migration-stats.h b/migration/migration-stats.h
> index 149af932d7..0e49c236fa 100644
> --- a/migration/migration-stats.h
> +++ b/migration/migration-stats.h
> @@ -22,17 +22,60 @@
>   * one thread).
>   */
>  typedef struct {
> +    /*
> +     * number of bytes that were dirty last time that we sync with the

 s/sync/synced/

> +     * guest memory.  We use that to calculate the downtime.  As the
> +     * remaining dirty amounts to what we know that is still dirty
> +     * since last iteration, not counting what the guest has dirtied
> +     * sync we synchronize bitmaps.

  s/synchronize/synchronized/

> +     */
>      Stat64 dirty_bytes_last_sync;
> +    /*
> +     * number of pages dirtied by second.

 s/by/per/

> +     */
>      Stat64 dirty_pages_rate;
> +    /*
> +     * number of times we have synchronize guest bitmaps.

  s/synchronize/synchronized/

>      Stat64 postcopy_bytes;
> +    /*
> +     * number of postcopy page faults that we have handled during
> +     * postocpy stage.

s/postocpy/postcopy/


Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  parent reply	other threads:[~2023-05-04 17:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-04 10:33 [PATCH 0/2] More migration stats Juan Quintela
2023-05-04 10:33 ` [PATCH 1/2] migration: Document all migration_stats Juan Quintela
2023-05-04 12:37   ` David Edmondson
2023-05-04 17:38     ` Juan Quintela
2023-05-04 16:47   ` Daniel P. Berrangé [this message]
2023-05-04 17:39     ` Juan Quintela
2023-05-04 10:33 ` [PATCH 2/2] migration: Put zero_pages in alphabetical order Juan Quintela
2023-05-04 12:38   ` David Edmondson
2023-05-04 16:47   ` Daniel P. Berrangé
2023-05-25 15:06   ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZFPhmrCnF8Rdkkxq@redhat.com \
    --to=berrange@redhat.com \
    --cc=leobras@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).