[PATCH 0/2] More migration stats

[PATCH 0/2] More migration stats

[Juan Quintela]

Hi

Just updating documentation for migration stats and sorting them.

Please review.

Juan Quintela (2):
  migration: Document all migration_stats
  migration: Put zero_pages in alphabetical order

 migration/migration-stats.h | 45 ++++++++++++++++++++++++++++++++++++-
 1 file changed, 44 insertions(+), 1 deletion(-)

-- 
2.40.0

[PATCH 1/2] migration: Document all migration_stats

[Juan Quintela]

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 migration/migration-stats.h | 43 +++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/migration/migration-stats.h b/migration/migration-stats.h
index 149af932d7..0e49c236fa 100644
--- a/migration/migration-stats.h
+++ b/migration/migration-stats.h
@@ -22,17 +22,60 @@
  * one thread).
  */
 typedef struct {
+    /*
+     * number of bytes that were dirty last time that we sync with the
+     * guest memory.  We use that to calculate the downtime.  As the
+     * remaining dirty amounts to what we know that is still dirty
+     * since last iteration, not counting what the guest has dirtied
+     * sync we synchronize bitmaps.
+     */
     Stat64 dirty_bytes_last_sync;
+    /*
+     * number of pages dirtied by second.
+     */
     Stat64 dirty_pages_rate;
+    /*
+     * number of times we have synchronize guest bitmaps.
+     */
     Stat64 dirty_sync_count;
+    /*
+     * number of times zero copy failed to send any page using zero
+     * copy.
+     */
     Stat64 dirty_sync_missed_zero_copy;
+    /*
+     * number of bytes sent at migration completion stage while the
+     * guest is stopped.
+     */
     Stat64 downtime_bytes;
+    /*
+     * number of pages transferred that were full of zeros.
+     */
     Stat64 zero_pages;
+    /*
+     * number of bytes sent through multifd channels.
+     */
     Stat64 multifd_bytes;
+    /*
+     * number of pages transferred that were not full of zeros.
+     */
     Stat64 normal_pages;
+    /*
+     * number of bytes sent during postcopy.
+     */
     Stat64 postcopy_bytes;
+    /*
+     * number of postcopy page faults that we have handled during
+     * postocpy stage.
+     */
     Stat64 postcopy_requests;
+    /*
+     *  number of bytes sent during precopy stage.
+     */
     Stat64 precopy_bytes;
+    /*
+     * total number of bytes transferred.
+     */
     Stat64 transferred;
 } MigrationAtomicStats;
 
-- 
2.40.0

[PATCH 2/2] migration: Put zero_pages in alphabetical order

[Juan Quintela]

I forgot to move it when I rename it from duplicated_pages.

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 migration/migration-stats.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/migration/migration-stats.h b/migration/migration-stats.h
index 0e49c236fa..b87ba30ea8 100644
--- a/migration/migration-stats.h
+++ b/migration/migration-stats.h
@@ -48,10 +48,6 @@ typedef struct {
      * guest is stopped.
      */
     Stat64 downtime_bytes;
-    /*
-     * number of pages transferred that were full of zeros.
-     */
-    Stat64 zero_pages;
     /*
      * number of bytes sent through multifd channels.
      */
@@ -77,6 +73,10 @@ typedef struct {
      * total number of bytes transferred.
      */
     Stat64 transferred;
+    /*
+     * number of pages transferred that were full of zeros.
+     */
+    Stat64 zero_pages;
 } MigrationAtomicStats;
 
 extern MigrationAtomicStats mig_stats;
-- 
2.40.0

Re: [PATCH 1/2] migration: Document all migration_stats

[David Edmondson]

Juan Quintela <quintela@redhat.com> writes:

> Signed-off-by: Juan Quintela <quintela@redhat.com>

Reviewed-by: David Edmondson <david.edmondson@oracle.com>

> ---
>  migration/migration-stats.h | 43 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
>
> diff --git a/migration/migration-stats.h b/migration/migration-stats.h
> index 149af932d7..0e49c236fa 100644
> --- a/migration/migration-stats.h
> +++ b/migration/migration-stats.h
> @@ -22,17 +22,60 @@
>   * one thread).
>   */
>  typedef struct {
> +    /*
> +     * number of bytes that were dirty last time that we sync with the

Minor, but given that you are writing sentences, please start with a
capital letter.

> +     * guest memory.  We use that to calculate the downtime.  As the
> +     * remaining dirty amounts to what we know that is still dirty
> +     * since last iteration, not counting what the guest has dirtied
> +     * sync we synchronize bitmaps.
> +     */
>      Stat64 dirty_bytes_last_sync;
> +    /*
> +     * number of pages dirtied by second.
> +     */
>      Stat64 dirty_pages_rate;
> +    /*
> +     * number of times we have synchronize guest bitmaps.
> +     */
>      Stat64 dirty_sync_count;
> +    /*
> +     * number of times zero copy failed to send any page using zero
> +     * copy.
> +     */
>      Stat64 dirty_sync_missed_zero_copy;
> +    /*
> +     * number of bytes sent at migration completion stage while the
> +     * guest is stopped.
> +     */
>      Stat64 downtime_bytes;
> +    /*
> +     * number of pages transferred that were full of zeros.
> +     */
>      Stat64 zero_pages;
> +    /*
> +     * number of bytes sent through multifd channels.
> +     */
>      Stat64 multifd_bytes;
> +    /*
> +     * number of pages transferred that were not full of zeros.
> +     */
>      Stat64 normal_pages;
> +    /*
> +     * number of bytes sent during postcopy.
> +     */
>      Stat64 postcopy_bytes;
> +    /*
> +     * number of postcopy page faults that we have handled during
> +     * postocpy stage.
> +     */
>      Stat64 postcopy_requests;
> +    /*
> +     *  number of bytes sent during precopy stage.

Spurious double space before 'number'.

> +     */
>      Stat64 precopy_bytes;
> +    /*
> +     * total number of bytes transferred.
> +     */
>      Stat64 transferred;
>  } MigrationAtomicStats;
>  
> -- 
> 2.40.0
-- 
I'm not the reason you're looking for redemption.

Re: [PATCH 2/2] migration: Put zero_pages in alphabetical order

[David Edmondson]

Juan Quintela <quintela@redhat.com> writes:

> I forgot to move it when I rename it from duplicated_pages.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>

Reviewed-by: David Edmondson <david.edmondson@oracle.com>

> ---
>  migration/migration-stats.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/migration/migration-stats.h b/migration/migration-stats.h
> index 0e49c236fa..b87ba30ea8 100644
> --- a/migration/migration-stats.h
> +++ b/migration/migration-stats.h
> @@ -48,10 +48,6 @@ typedef struct {
>       * guest is stopped.
>       */
>      Stat64 downtime_bytes;
> -    /*
> -     * number of pages transferred that were full of zeros.
> -     */
> -    Stat64 zero_pages;
>      /*
>       * number of bytes sent through multifd channels.
>       */
> @@ -77,6 +73,10 @@ typedef struct {
>       * total number of bytes transferred.
>       */
>      Stat64 transferred;
> +    /*
> +     * number of pages transferred that were full of zeros.
> +     */
> +    Stat64 zero_pages;
>  } MigrationAtomicStats;
>  
>  extern MigrationAtomicStats mig_stats;
> -- 
> 2.40.0
-- 
I've got a little black book with my poems in.

Re: [PATCH 1/2] migration: Document all migration_stats

[Daniel P. Berrangé]

On Thu, May 04, 2023 at 12:33:56PM +0200, Juan Quintela wrote:
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  migration/migration-stats.h | 43 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
> 
> diff --git a/migration/migration-stats.h b/migration/migration-stats.h
> index 149af932d7..0e49c236fa 100644
> --- a/migration/migration-stats.h
> +++ b/migration/migration-stats.h
> @@ -22,17 +22,60 @@
>   * one thread).
>   */
>  typedef struct {
> +    /*
> +     * number of bytes that were dirty last time that we sync with the

 s/sync/synced/

> +     * guest memory.  We use that to calculate the downtime.  As the
> +     * remaining dirty amounts to what we know that is still dirty
> +     * since last iteration, not counting what the guest has dirtied
> +     * sync we synchronize bitmaps.

  s/synchronize/synchronized/

> +     */
>      Stat64 dirty_bytes_last_sync;
> +    /*
> +     * number of pages dirtied by second.

 s/by/per/

> +     */
>      Stat64 dirty_pages_rate;
> +    /*
> +     * number of times we have synchronize guest bitmaps.

  s/synchronize/synchronized/

>      Stat64 postcopy_bytes;
> +    /*
> +     * number of postcopy page faults that we have handled during
> +     * postocpy stage.

s/postocpy/postcopy/


Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH 2/2] migration: Put zero_pages in alphabetical order

[Daniel P. Berrangé]

On Thu, May 04, 2023 at 12:33:57PM +0200, Juan Quintela wrote:
> I forgot to move it when I rename it from duplicated_pages.
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  migration/migration-stats.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH 1/2] migration: Document all migration_stats

[Juan Quintela]

David Edmondson <david.edmondson@oracle.com> wrote:
> Juan Quintela <quintela@redhat.com> writes:
>
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>
> Reviewed-by: David Edmondson <david.edmondson@oracle.com>

Thanks.

>> ---
>>  migration/migration-stats.h | 43 +++++++++++++++++++++++++++++++++++++
>>  1 file changed, 43 insertions(+)
>>
>> diff --git a/migration/migration-stats.h b/migration/migration-stats.h
>> index 149af932d7..0e49c236fa 100644
>> --- a/migration/migration-stats.h
>> +++ b/migration/migration-stats.h
>> @@ -22,17 +22,60 @@
>>   * one thread).
>>   */
>>  typedef struct {
>> +    /*
>> +     * number of bytes that were dirty last time that we sync with the
>
> Minor, but given that you are writing sentences, please start with a
> capital letter.

Done.

>
>> +     * guest memory.  We use that to calculate the downtime.  As the
>> +     * remaining dirty amounts to what we know that is still dirty
>> +     * since last iteration, not counting what the guest has dirtied
>> +     * sync we synchronize bitmaps.
>> +     */
>>      Stat64 dirty_bytes_last_sync;
>> +    /*
>> +     * number of pages dirtied by second.
>> +     */
>>      Stat64 dirty_pages_rate;
>> +    /*
>> +     * number of times we have synchronize guest bitmaps.
>> +     */
>>      Stat64 dirty_sync_count;
>> +    /*
>> +     * number of times zero copy failed to send any page using zero
>> +     * copy.
>> +     */
>>      Stat64 dirty_sync_missed_zero_copy;
>> +    /*
>> +     * number of bytes sent at migration completion stage while the
>> +     * guest is stopped.
>> +     */
>>      Stat64 downtime_bytes;
>> +    /*
>> +     * number of pages transferred that were full of zeros.
>> +     */
>>      Stat64 zero_pages;
>> +    /*
>> +     * number of bytes sent through multifd channels.
>> +     */
>>      Stat64 multifd_bytes;
>> +    /*
>> +     * number of pages transferred that were not full of zeros.
>> +     */
>>      Stat64 normal_pages;
>> +    /*
>> +     * number of bytes sent during postcopy.
>> +     */
>>      Stat64 postcopy_bytes;
>> +    /*
>> +     * number of postcopy page faults that we have handled during
>> +     * postocpy stage.
>> +     */
>>      Stat64 postcopy_requests;
>> +    /*
>> +     *  number of bytes sent during precopy stage.
>
> Spurious double space before 'number'.

Done.

Re: [PATCH 1/2] migration: Document all migration_stats

[Juan Quintela]

Daniel P. Berrangé <berrange@redhat.com> wrote:
> On Thu, May 04, 2023 at 12:33:56PM +0200, Juan Quintela wrote:
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> ---
>>  migration/migration-stats.h | 43 +++++++++++++++++++++++++++++++++++++
>>  1 file changed, 43 insertions(+)
>> 
>> diff --git a/migration/migration-stats.h b/migration/migration-stats.h
>> index 149af932d7..0e49c236fa 100644
>> --- a/migration/migration-stats.h
>> +++ b/migration/migration-stats.h
>> @@ -22,17 +22,60 @@
>>   * one thread).
>>   */
>>  typedef struct {
>> +    /*
>> +     * number of bytes that were dirty last time that we sync with the
>
>  s/sync/synced/
>
>> +     * guest memory.  We use that to calculate the downtime.  As the
>> +     * remaining dirty amounts to what we know that is still dirty
>> +     * since last iteration, not counting what the guest has dirtied
>> +     * sync we synchronize bitmaps.
>
>   s/synchronize/synchronized/
>
>> +     */
>>      Stat64 dirty_bytes_last_sync;
>> +    /*
>> +     * number of pages dirtied by second.
>
>  s/by/per/
>
>> +     */
>>      Stat64 dirty_pages_rate;
>> +    /*
>> +     * number of times we have synchronize guest bitmaps.
>
>   s/synchronize/synchronized/
>
>>      Stat64 postcopy_bytes;
>> +    /*
>> +     * number of postcopy page faults that we have handled during
>> +     * postocpy stage.
>
> s/postocpy/postcopy/

Integrated all of them.

>
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Thanks.

>
> With regards,
> Daniel

Re: [PATCH 2/2] migration: Put zero_pages in alphabetical order

[Peter Xu]

On Thu, May 04, 2023 at 12:33:57PM +0200, Juan Quintela wrote:
> I forgot to move it when I rename it from duplicated_pages.
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>

Reviewed-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu