From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org, Leonardo Bras <leobras@redhat.com>,
Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH 5/5] migration/rdma: Check for postcopy sooner
Date: Thu, 4 May 2023 18:05:52 +0100 [thread overview]
Message-ID: <ZFPl8DMq/NxB6srX@redhat.com> (raw)
In-Reply-To: <20230504114443.23891-6-quintela@redhat.com>
On Thu, May 04, 2023 at 01:44:43PM +0200, Juan Quintela wrote:
> It makes no sense first try to see if there is an rdma error and then
> do nothing on postcopy stage. Change it so we check we are in
> postcopy before doing anything.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
> migration/rdma.c | 34 +++++++++++++++++-----------------
> 1 file changed, 17 insertions(+), 17 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2023-05-04 17:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 11:44 [PATCH 0/5] Migration RDMA cleanup Juan Quintela
2023-05-04 11:44 ` [PATCH 1/5] migration: Make RAM_SAVE_FLAG_HOOK a normal case entry Juan Quintela
2023-05-04 17:03 ` Daniel P. Berrangé
2023-05-26 21:09 ` Peter Xu
2023-05-04 11:44 ` [PATCH 2/5] migration/rdma: simplify ram_control_load_hook() Juan Quintela
2023-05-04 17:03 ` Daniel P. Berrangé
2023-05-26 21:10 ` Peter Xu
2023-05-04 11:44 ` [PATCH 3/5] migration/rdma: We can calculate the rioc from the QEMUFile Juan Quintela
2023-05-04 17:04 ` Daniel P. Berrangé
2023-05-26 21:10 ` Peter Xu
2023-05-04 11:44 ` [PATCH 4/5] migration/rdma: It makes no sense to recive that flag without RDMA Juan Quintela
2023-05-04 17:05 ` Daniel P. Berrangé
2023-05-04 22:53 ` Juan Quintela
2023-05-26 21:15 ` Peter Xu
2023-05-04 11:44 ` [PATCH 5/5] migration/rdma: Check for postcopy sooner Juan Quintela
2023-05-04 17:05 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFPl8DMq/NxB6srX@redhat.com \
--to=berrange@redhat.com \
--cc=leobras@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).