From: Peter Xu <peterx@redhat.com>
To: Gavin Shan <gshan@redhat.com>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, pbonzini@redhat.com,
peter.maydell@linaro.org, david@redhat.com, philmd@linaro.org,
mst@redhat.com, cohuck@redhat.com, quintela@redhat.com,
dgilbert@redhat.com, maz@kernel.org, zhenyzha@redhat.com,
shan.gavin@gmail.com
Subject: Re: [PATCH v3 4/4] kvm: Enable dirty ring for arm64
Date: Tue, 9 May 2023 06:54:09 -0700 [thread overview]
Message-ID: <ZFpQgbiyOq2Eu82I@x1n> (raw)
In-Reply-To: <20230509022122.20888-5-gshan@redhat.com>
On Tue, May 09, 2023 at 12:21:22PM +1000, Gavin Shan wrote:
> arm64 has different capability from x86 to enable the dirty ring, which
> is KVM_CAP_DIRTY_LOG_RING_ACQ_REL. Besides, arm64 also needs the backup
> bitmap extension (KVM_CAP_DIRTY_LOG_RING_WITH_BITMAP) when 'kvm-arm-gicv3'
> or 'arm-its-kvm' device is enabled. Here the extension is always enabled
> and the unnecessary overhead to do the last stage of dirty log synchronization
> when those two devices aren't used is introduced, but the overhead should
> be very small and acceptable. The benefit is cover future cases where those
> two devices are used without modifying the code.
>
> Signed-off-by: Gavin Shan <gshan@redhat.com>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
> Tested-by: Zhenyu Zhang <zhenyzha@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2023-05-09 13:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 2:21 [PATCH v3 0/4] hw/arm/virt: Support dirty ring Gavin Shan
2023-05-09 2:21 ` [PATCH v3 1/4] migration: Add last stage indicator to global dirty log Gavin Shan
2023-05-09 2:21 ` [PATCH v3 2/4] kvm: Synchronize the backup bitmap in the last stage Gavin Shan
2023-05-09 2:21 ` [PATCH v3 3/4] kvm: Add helper kvm_dirty_ring_init() Gavin Shan
2023-05-09 2:21 ` [PATCH v3 4/4] kvm: Enable dirty ring for arm64 Gavin Shan
2023-05-09 13:54 ` Peter Xu [this message]
2023-05-09 2:28 ` [PATCH v3 0/4] hw/arm/virt: Support dirty ring Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFpQgbiyOq2Eu82I@x1n \
--to=peterx@redhat.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=gshan@redhat.com \
--cc=maz@kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=shan.gavin@gmail.com \
--cc=zhenyzha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).