Re: [PATCH v2 1/3] hw/i2c: add mctp core

[Klaus Jensen <its@irrelevant.dk>]

[-- Attachment #1: Type: text/plain, Size: 1276 bytes --]

On May 25 12:27, Jonathan Cameron wrote:
> On Tue, 25 Apr 2023 08:35:38 +0200
> Klaus Jensen <its@irrelevant.dk> wrote:
> 
> > From: Klaus Jensen <k.jensen@samsung.com>
> > 
> > Add an abstract MCTP over I2C endpoint model. This implements MCTP
> > control message handling as well as handling the actual I2C transport
> > (packetization).
> > 
> > Devices are intended to derive from this and implement the class
> > methods.
> > 
> > Parts of this implementation is inspired by code[1] previously posted by
> > Jonathan Cameron.
> > 
> >   [1]: https://lore.kernel.org/qemu-devel/20220520170128.4436-1-Jonathan.Cameron@huawei.com/
> > 
> > Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> 
> This is very useful for the CXL MCTP CCI support - got rid of most of the
> nasty code when I moved over to using this (will post code shortly)
> 
> A few comments inline - but all trivial stuff.
> 
> What I can give now though is:
> Tested-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 

Hi Jonathan,

This came at just the right time! I was finally preparing v3 since Lior
is also requesting that this gets merged sooner rather than later ;)

I'll work in your very resonable comments (thanks!) and ship it.


Thanks again,
Klaus

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]