From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-devel@nongnu.org,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Beraldo Leal" <bleal@redhat.com>
Subject: Re: [PATCH 5/5] gitlab: support disabling job auto-run in upstream
Date: Wed, 17 May 2023 16:38:44 +0100 [thread overview]
Message-ID: <ZGT1BGbWPipLnk0o@redhat.com> (raw)
In-Reply-To: <b0086f66-fe64-e38e-ce77-f3441401d013@tls.msk.ru>
On Wed, May 17, 2023 at 06:13:44PM +0300, Michael Tokarev wrote:
> 17.05.2023 16:54, Daniel P. Berrangé wrote:
> > In forks QEMU_CI=1 can be used to create a pipeline but not auto-run any
> > jobs. In upstream jobs always auto-run, which is equiv of QEMU_CI=2.
> >
> > This supports setting QEMU_CI=1 in upstream, to disable job auto-run.
> > This can be used to preserve CI minutes if repushing a branch to staging
> > with a specific fix that only needs testing in limited scenarios.
> >
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> > .gitlab-ci.d/base.yml | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/.gitlab-ci.d/base.yml b/.gitlab-ci.d/base.yml
> > index 999149852e..188a770799 100644
> > --- a/.gitlab-ci.d/base.yml
> > +++ b/.gitlab-ci.d/base.yml
> > @@ -109,6 +109,16 @@ variables:
> > - if: '$QEMU_CI != "2" && $CI_PROJECT_NAMESPACE != $QEMU_CI_UPSTREAM'
> > when: manual
> > + # Upstream pipeline jobs start automatically unless told not to
> > + # by setting QEMU_CI=1
> > + - if: '$QEMU_CI == "1" && $CI_PROJECT_NAMESPACE == $QEMU_CI_UPSTREAM && $CI_COMMIT_BRANCH =~ /staging-[[:digit:]]+\.[[:digit:]]/'
>
> Should this be enabled for main staging branch too?
> I dunno how it is useful though.
Yes, actually it should have been. There's no downside to enabling it for
'staging' too, since it is opt-in.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2023-05-17 15:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 13:54 [PATCH 0/5] gitlab: improvements to handling of stable staging branches Daniel P. Berrangé
2023-05-17 13:54 ` [PATCH 1/5] gitlab: centralize the container tag name Daniel P. Berrangé
2023-05-17 15:17 ` Michael Tokarev
2023-05-17 20:01 ` Richard Henderson
2023-05-26 7:25 ` Thomas Huth
2023-05-26 10:20 ` Daniel P. Berrangé
2023-05-26 10:31 ` Thomas Huth
2023-05-26 10:33 ` Daniel P. Berrangé
2023-05-17 13:54 ` [PATCH 2/5] gitlab: allow overriding name of the upstream repository Daniel P. Berrangé
2023-05-17 15:18 ` Michael Tokarev
2023-05-17 13:54 ` [PATCH 3/5] gitlab: stable staging branches publish containers in a separate tag Daniel P. Berrangé
2023-05-17 15:26 ` Michael Tokarev
2023-05-17 15:37 ` Daniel P. Berrangé
2023-05-17 13:54 ` [PATCH 4/5] gitlab: avoid extra pipelines for tags and stable branches Daniel P. Berrangé
2023-05-17 15:27 ` Michael Tokarev
2023-05-17 13:54 ` [PATCH 5/5] gitlab: support disabling job auto-run in upstream Daniel P. Berrangé
2023-05-17 15:13 ` Michael Tokarev
2023-05-17 15:38 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGT1BGbWPipLnk0o@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=bleal@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).