From: Peter Xu <peterx@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Andrei Gudkov <gudkov.andrei@huawei.com>,
qemu-devel@nongnu.org, quintela@redhat.com, leobras@redhat.com,
eblake@redhat.com
Subject: Re: [PATCH] qapi: better docs for calc-dirty-rate and friends
Date: Fri, 26 May 2023 09:36:44 -0400 [thread overview]
Message-ID: <ZHC17O1pmkLBmcV/@x1n> (raw)
In-Reply-To: <87y1lbbalg.fsf@pond.sub.org>
On Fri, May 26, 2023 at 01:23:07PM +0200, Markus Armbruster wrote:
> Going with
>
> # 2. Dirty bitmap mode captures writes to memory (for example by
> # temporarily revoking write access to all pages) and counting page
> # faults. Information about modified pages is collected into a
> # bitmap, where each bit corresponds to one guest page. This mode
> # requires that KVM accelerator property "dirty-ring-size" is *not*
> # set.
>
> if you don't mind.
Looks good here, thanks!
--
Peter Xu
next prev parent reply other threads:[~2023-05-26 13:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 15:19 [PATCH] qapi: better docs for calc-dirty-rate and friends Andrei Gudkov via
2023-05-25 13:08 ` Markus Armbruster
2023-05-25 13:30 ` Peter Xu
2023-05-26 11:23 ` Markus Armbruster
2023-05-26 13:36 ` Peter Xu [this message]
2023-05-26 9:25 ` gudkov.andrei--- via
2023-05-26 11:24 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHC17O1pmkLBmcV/@x1n \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=gudkov.andrei@huawei.com \
--cc=leobras@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).