qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Ján Tomko" <jtomko@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Peter Krempa <pkrempa@redhat.com>,
	libvir-list@redhat.com, Andrea Bolognani <abologna@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: query-command-line-options
Date: Fri, 26 May 2023 13:07:10 +0200	[thread overview]
Message-ID: <ZHCS3vXnyE9ouEf3@fedora> (raw)
In-Reply-To: <87sfbjcw0s.fsf@pond.sub.org>

[-- Attachment #1: Type: text/plain, Size: 965 bytes --]

On a Friday in 2023, Markus Armbruster wrote:
>>     { "sandbox", NULL, QEMU_CAPS_SECCOMP_SANDBOX },
>
>Does option -sandbox exist?
>
>It does since v1.2.  If CONFIG_SECCOMP is off, actually using it is a
>fatal error.  Compiling out the option entirely would be more useful, I
>guess.
>
>Is this probe still useful?

I believe so.

libvirt adds '-sandbox on' to all VMs it runs, unless the option is not
available.

Some users wanted to run libvirt with QEMUs without libseccomp,
which resulted in the following QEMU commit.

commit 0dd693ef1f15b6e9c4ba8b0118663e10338077cf
     sandbox: disable -sandbox if CONFIG_SECCOMP undefined

While using this option won't work if CONFIG_SECCOMP is off,
it should not show up in q-c-l-o so libvirt won't even try to use it.


If I'm reading
  commit 90835c2b8127406615785a9d4348ffdf3c813c8a
      seccomp: convert to meson
correctly, then the whole softmmu/qemu-seccomp.c file is only compiled
if seccomp was found.

Jano


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2023-05-26 11:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1677511354.git.pkrempa@redhat.com>
     [not found] ` <8718b22eda052662087087b4ce659b054974c9e0.1677511354.git.pkrempa@redhat.com>
     [not found]   ` <CABJz62PHsQHiyo06PtfcDeS1LddYyDw2pC_seObtZcLR5cPQyQ@mail.gmail.com>
     [not found]     ` <Y/zng8+7s05O0tRd@angien.pipo.sk>
     [not found]       ` <CABJz62OMWXAx_ExYqvvg1DvcHkiP+SkwNMQZ+56QwoHpsNBqGA@mail.gmail.com>
2023-03-07  9:40         ` query-command-line-options (was: [PATCH 1/7] qemu: capabilities: Introduce QEMU_CAPS_MACHINE_ACPI) Markus Armbruster
2023-03-07 14:28           ` Peter Krempa
2023-05-26  8:54             ` query-command-line-options Markus Armbruster
2023-05-26 11:07               ` Ján Tomko [this message]
2023-05-26 12:10                 ` query-command-line-options Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZHCS3vXnyE9ouEf3@fedora \
    --to=jtomko@redhat.com \
    --cc=abologna@redhat.com \
    --cc=armbru@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=pkrempa@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).