From: Peter Xu <peterx@redhat.com>
To: Fiona Ebner <f.ebner@proxmox.com>
Cc: qemu-devel@nongnu.org, andrey.gruzdev@virtuozzo.com,
quintela@redhat.com, leobras@redhat.com
Subject: Re: [PATCH] migration: stop tracking ram writes when cancelling background migration
Date: Fri, 26 May 2023 18:01:24 -0400 [thread overview]
Message-ID: <ZHEsNGAPTCGVaps+@x1n> (raw)
In-Reply-To: <20230526115908.196171-1-f.ebner@proxmox.com>
On Fri, May 26, 2023 at 01:59:08PM +0200, Fiona Ebner wrote:
> Currently, it is only done when the iteration finishes successfully.
> Not cleaning up the userfaultfd write protection can lead to
> symptoms/issues such as the process hanging in memmove or GDB not
> being able to attach.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
> For the success case, the stuff in between the old call and new call
> site should not depend on tracking to already be stopped, right?
Yes I think so. There's only device states to be flushed and no guest
memory should be touched.
Even if we'll touch them, since we've finished migrating all of them so
they're already unprotected anyway (actually, even during ram save it's
read-only here from bg thread), so not any problem I can see.
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2023-05-26 22:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 11:59 [PATCH] migration: stop tracking ram writes when cancelling background migration Fiona Ebner
2023-05-26 22:01 ` Peter Xu [this message]
2023-05-30 18:45 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHEsNGAPTCGVaps+@x1n \
--to=peterx@redhat.com \
--cc=andrey.gruzdev@virtuozzo.com \
--cc=f.ebner@proxmox.com \
--cc=leobras@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).