From: Jason Gunthorpe <jgg@nvidia.com>
To: "Liu, Yi L" <yi.l.liu@intel.com>
Cc: Jason Wang <jasowang@redhat.com>,
"Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
Peter Xu <peterx@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"mst@redhat.com" <mst@redhat.com>,
"marcel.apfelbaum@gmail.com" <marcel.apfelbaum@gmail.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"richard.henderson@linaro.org" <richard.henderson@linaro.org>,
"eduardo@habkost.net" <eduardo@habkost.net>,
"Peng, Chao P" <chao.p.peng@intel.com>,
Kirti Wankhede <kwankhede@nvidia.com>, Neo Jia <cjia@nvidia.com>,
Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PATCH] intel_iommu: Optimize out some unnecessary UNMAP calls
Date: Mon, 29 May 2023 14:00:49 -0300 [thread overview]
Message-ID: <ZHTaQXd3ZybmhCLb@nvidia.com> (raw)
In-Reply-To: <DS0PR11MB75294EE1B95AE1953825B845C3479@DS0PR11MB7529.namprd11.prod.outlook.com>
On Fri, May 26, 2023 at 08:44:29AM +0000, Liu, Yi L wrote:
> > > >> In fact, the other purpose of this patch is to eliminate noisy error
> > > >> log when we work with IOMMUFD. It looks the duplicate UNMAP call will
> > > >> fail with IOMMUFD while always succeed with legacy container. This
> > > >> behavior difference lead to below error log for IOMMUFD:
> >
> > A dumb question, should IOMMUFD stick the same behaviour with legacy container?
>
> May need to hear from JasonG. 😊 Should IOMMU_IOAS_UNMAP return error or
> success if the iova is not found?
The native iommufd functions will return failure if they could not
unmap anything.
Otherwise they return the number of consecutive bytes unmapped.
The VFIO emulation functions should do whatever VFIO does, is there a
mistake there?
Jason
prev parent reply other threads:[~2023-05-29 17:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 8:07 [PATCH] intel_iommu: Optimize out some unnecessary UNMAP calls Zhenzhong Duan
2023-05-24 16:58 ` Peter Xu
2023-05-25 11:29 ` Duan, Zhenzhong
2023-05-25 13:53 ` Peter Xu
2023-05-26 6:22 ` Duan, Zhenzhong
2023-05-26 6:28 ` Jason Wang
2023-05-26 8:44 ` Liu, Yi L
2023-05-29 17:00 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHTaQXd3ZybmhCLb@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=chao.p.peng@intel.com \
--cc=cjia@nvidia.com \
--cc=eduardo@habkost.net \
--cc=jasowang@redhat.com \
--cc=kwankhede@nvidia.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=yi.l.liu@intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).