From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E16B1C77B7A for ; Tue, 30 May 2023 12:17:52 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q3yHs-0006E1-Qc; Tue, 30 May 2023 08:17:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3yHo-0006DJ-Gc for qemu-devel@nongnu.org; Tue, 30 May 2023 08:17:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3yHm-0006e8-Fo for qemu-devel@nongnu.org; Tue, 30 May 2023 08:17:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685449029; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FL1KBidFMAPWCwo1oGmz8F8qDk0ZwsjUehX6YpejCr8=; b=WxkGm8Z/sPAxU4il/cAUCoNzm6smh/evbvIYEjMUKtV6AOJJinBgZvlFrZynb4xn74ko9g pm5xU+tH4k9xm1iFyNyABHiuOev6Mfb/mnvwbLaU8DSRoEvD0nh7x/7D57GPlUpPK0eMia mBGAn3f7IasfBrjfLCAhSbyLTgpDNgw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-591-Krt-i-UtOiWwJx98VVQaog-1; Tue, 30 May 2023 08:17:06 -0400 X-MC-Unique: Krt-i-UtOiWwJx98VVQaog-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D0D33185A79B; Tue, 30 May 2023 12:17:05 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.167]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3646720296C6; Tue, 30 May 2023 12:17:05 +0000 (UTC) Date: Tue, 30 May 2023 13:17:03 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Paolo Bonzini Cc: Thomas Huth , qemu-devel@nongnu.org, peter.maydell@linaro.org Subject: Re: [PATCH 1/5] configure: remove --with-git= option Message-ID: References: <20230527092851.705884-1-pbonzini@redhat.com> <20230527092851.705884-2-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.167, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, May 30, 2023 at 02:03:11PM +0200, Paolo Bonzini wrote: > On Tue, May 30, 2023 at 1:58 PM Thomas Huth wrote: > > The commit cc84d63a42e31c2a that introduce this switch gave a > > rationale: > > > > Some users can't run a bare 'git' command, due to need for a transparent > > proxying solution such as 'tsocks'. This adds an argument to configure to > > let users specify such a thing: > > > > ./configure --with-git="tsocks git" > > I see, thanks for the additional information--it makes sense to > include it in the commit message. > > My impression is that the "smart HTTP" protocol has made this concern > less important. Smart HTTP was introduced in 2009, but back in 2017 > the git protocol running on port 9418 was still quite common. QEMU > itself switched from git to https in 2018 with commit a897f22b596b62, > about a year after --with-git was introduced. Here is the original thread: https://lists.nongnu.org/archive/html/qemu-devel/2017-10/msg05005.html yes it was about 'git://' protocol, and yes, creating a wrapper script call 'git' was a viable option too. I just added --with-git as a convenience. > > But if the plain "git" command is unusable on their system, > > they should likely introduce a proper wrapper on their end > > for this command anyway, so IMHO it's ok if we remove this > > again. Daniel, what do you think? > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|