From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, thuth@redhat.com
Subject: Re: [PATCH 1/5] configure: remove --with-git= option
Date: Tue, 30 May 2023 13:18:21 +0100 [thread overview]
Message-ID: <ZHXpjUP0E8b48nYy@redhat.com> (raw)
In-Reply-To: <20230527092851.705884-2-pbonzini@redhat.com>
On Sat, May 27, 2023 at 11:28:47AM +0200, Paolo Bonzini wrote:
> There is not really any scenario where one would use any other git
> binary than "the first git in the PATH" aka $(command -v git). In
> fact for example "meson subprojects download" or scripts/checkpatch.pl
> do not obey the GIT environment variable.
>
> Remove the unnecessary knob, but test for the presence of git in
> the configure and git-submodule.sh scripts.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> Makefile | 2 +-
> configure | 6 ++----
> meson.build | 1 -
> scripts/git-submodule.sh | 8 +++++++-
> 4 files changed, 10 insertions(+), 7 deletions(-)
If you just update the commit message to say we are intentionally
reverting functionality from cc84d63a42e31c2afa884fc78610a65ab8ecc06a
and people should create a wrapper script instead:
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-05-30 12:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-27 9:28 [PATCH 0/5] meson: replace submodules with wrap files Paolo Bonzini
2023-05-27 9:28 ` [PATCH 1/5] configure: remove --with-git= option Paolo Bonzini
2023-05-30 11:58 ` Thomas Huth
2023-05-30 12:03 ` Paolo Bonzini
2023-05-30 12:17 ` Daniel P. Berrangé
2023-05-30 12:18 ` Daniel P. Berrangé [this message]
2023-05-27 9:28 ` [PATCH 2/5] configure: rename --enable-pypi to --enable-download, control subprojects too Paolo Bonzini
2023-05-27 16:49 ` BALATON Zoltan
2023-05-27 19:18 ` Paolo Bonzini
2023-05-30 12:00 ` Thomas Huth
2023-05-27 9:28 ` [PATCH 3/5] meson: subprojects: replace submodules with wrap files Paolo Bonzini
2023-05-30 12:23 ` Daniel P. Berrangé
2023-05-30 12:51 ` Paolo Bonzini
2023-05-30 12:54 ` Daniel P. Berrangé
2023-05-27 9:28 ` [PATCH 4/5] configure: check for SLOF submodule before building pc-bios/s390-ccw Paolo Bonzini
2023-05-30 12:04 ` Thomas Huth
2023-05-30 12:53 ` Paolo Bonzini
2023-05-30 13:00 ` Thomas Huth
2023-05-27 9:28 ` [PATCH 5/5] meson: subprojects: replace berkeley-{soft, test}float-3 with wraps Paolo Bonzini
2023-05-30 12:18 ` [PATCH 0/5] meson: replace submodules with wrap files Thomas Huth
2023-05-30 12:57 ` Daniel P. Berrangé
2023-05-30 13:22 ` Paolo Bonzini
2023-05-30 12:30 ` Daniel P. Berrangé
2023-05-30 12:47 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHXpjUP0E8b48nYy@redhat.com \
--to=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).