From: Peter Xu <peterx@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: quintela@redhat.com, qemu-devel@nongnu.org,
Peter Maydell <peter.maydell@linaro.org>,
Jiang Jiacheng <jiangjiacheng@huawei.com>,
Leonardo Bras <leobras@redhat.com>
Subject: Re: [PATCH 2/3] migration/multifd: Protect accesses to migration_threads
Date: Wed, 7 Jun 2023 09:25:46 -0400 [thread overview]
Message-ID: <ZICFWm+qTOHBgzzN@x1n> (raw)
In-Reply-To: <87o7lrh48h.fsf@suse.de>
On Wed, Jun 07, 2023 at 09:00:14AM -0300, Fabiano Rosas wrote:
> >> diff --git a/migration/migration.c b/migration/migration.c
> >> index e731fc98a1..b3b8345eb2 100644
> >> --- a/migration/migration.c
> >> +++ b/migration/migration.c
> >> @@ -1146,6 +1146,7 @@ static void migrate_fd_cleanup(MigrationState *s)
> >> qemu_mutex_lock_iothread();
> >>
> >> multifd_save_cleanup();
> >> + qmp_migration_threads_cleanup();
> >
> > I think I will spare this one as the mutex is static, so we are not
> > winning any memory back.
> >
>
> Ok
We could consider __attribute__((__constructor__)) in this case.
--
Peter Xu
next prev parent reply other threads:[~2023-06-07 13:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 14:45 [PATCH 0/3] migration: Fix multifd cancel test Fabiano Rosas
2023-06-06 14:45 ` [PATCH 1/3] migration/multifd: Rename threadinfo.c functions Fabiano Rosas
2023-06-06 18:38 ` Peter Xu
2023-06-06 19:34 ` Fabiano Rosas
2023-06-06 20:03 ` Peter Xu
2023-06-07 6:30 ` Juan Quintela
2023-06-07 7:56 ` Philippe Mathieu-Daudé
2023-06-06 14:45 ` [PATCH 2/3] migration/multifd: Protect accesses to migration_threads Fabiano Rosas
2023-06-06 18:43 ` Peter Xu
2023-06-07 8:26 ` Juan Quintela
2023-06-07 12:00 ` Fabiano Rosas
2023-06-07 13:25 ` Peter Xu [this message]
2023-06-07 16:58 ` Juan Quintela
2023-06-06 14:45 ` [PATCH 3/3] tests/qtest: Re-enable multifd cancel test Fabiano Rosas
2023-06-07 8:27 ` Juan Quintela
2024-01-08 6:42 ` Peter Xu
2024-01-08 14:26 ` Fabiano Rosas
2024-01-09 2:12 ` Peter Xu
2024-01-09 7:21 ` Thomas Huth
2024-01-09 7:48 ` Peter Xu
2024-01-09 8:44 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZICFWm+qTOHBgzzN@x1n \
--to=peterx@redhat.com \
--cc=farosas@suse.de \
--cc=jiangjiacheng@huawei.com \
--cc=leobras@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).