qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] keymaps: use 'ara' X11 keyboard map instead of 'ar'
@ 2023-06-23  9:40 Daniel P. Berrangé
  2023-06-23 10:12 ` Peter Maydell
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel P. Berrangé @ 2023-06-23  9:40 UTC (permalink / raw)
  To: qemu-devel; +Cc: Miroslav Rezanina, Gerd Hoffmann, Daniel P. Berrangé

The keyboard mapping name 'ar' was a legacy name only available from
xkeyboard-config via a (15 year old) backcompat mapping. This mapping
was finally removed in the latest upstream release 2.39:

  https://gitlab.freedesktop.org/xkeyboard-config/xkeyboard-config/-/commit/470ad2cd8fea84d7210377161d86b31999bb5ea6

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 pc-bios/keymaps/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pc-bios/keymaps/meson.build b/pc-bios/keymaps/meson.build
index bff3083313..0bd8ce0077 100644
--- a/pc-bios/keymaps/meson.build
+++ b/pc-bios/keymaps/meson.build
@@ -1,5 +1,5 @@
 keymaps = {
-  'ar': '-l ar',
+  'ar': '-l ara',
   'bepo': '-l fr -v dvorak',
   'cz': '-l cz',
   'da': '-l dk',
-- 
2.40.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] keymaps: use 'ara' X11 keyboard map instead of 'ar'
  2023-06-23  9:40 [PATCH] keymaps: use 'ara' X11 keyboard map instead of 'ar' Daniel P. Berrangé
@ 2023-06-23 10:12 ` Peter Maydell
  2023-06-23 10:27   ` Daniel P. Berrangé
  0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2023-06-23 10:12 UTC (permalink / raw)
  To: Daniel P. Berrangé; +Cc: qemu-devel, Miroslav Rezanina, Gerd Hoffmann

On Fri, 23 Jun 2023 at 10:40, Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> The keyboard mapping name 'ar' was a legacy name only available from
> xkeyboard-config via a (15 year old) backcompat mapping. This mapping
> was finally removed in the latest upstream release 2.39:
>
>   https://gitlab.freedesktop.org/xkeyboard-config/xkeyboard-config/-/commit/470ad2cd8fea84d7210377161d86b31999bb5ea6

Hi; I sent a patch to fix this a couple of days ago:
https://patchew.org/QEMU/20230620162024.1132013-1-peter.maydell@linaro.org/
(That one's already been reviewed and has a bit more detail
in its commit message.)

thanks
-- PMM


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] keymaps: use 'ara' X11 keyboard map instead of 'ar'
  2023-06-23 10:12 ` Peter Maydell
@ 2023-06-23 10:27   ` Daniel P. Berrangé
  0 siblings, 0 replies; 3+ messages in thread
From: Daniel P. Berrangé @ 2023-06-23 10:27 UTC (permalink / raw)
  To: Peter Maydell; +Cc: qemu-devel, Miroslav Rezanina, Gerd Hoffmann

On Fri, Jun 23, 2023 at 11:12:13AM +0100, Peter Maydell wrote:
> On Fri, 23 Jun 2023 at 10:40, Daniel P. Berrangé <berrange@redhat.com> wrote:
> >
> > The keyboard mapping name 'ar' was a legacy name only available from
> > xkeyboard-config via a (15 year old) backcompat mapping. This mapping
> > was finally removed in the latest upstream release 2.39:
> >
> >   https://gitlab.freedesktop.org/xkeyboard-config/xkeyboard-config/-/commit/470ad2cd8fea84d7210377161d86b31999bb5ea6
> 
> Hi; I sent a patch to fix this a couple of days ago:
> https://patchew.org/QEMU/20230620162024.1132013-1-peter.maydell@linaro.org/
> (That one's already been reviewed and has a bit more detail
> in its commit message.)

Ah perfect, sorry I missed that.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-06-23 10:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-23  9:40 [PATCH] keymaps: use 'ara' X11 keyboard map instead of 'ar' Daniel P. Berrangé
2023-06-23 10:12 ` Peter Maydell
2023-06-23 10:27   ` Daniel P. Berrangé

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).