From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, "Thomas Huth" <thuth@redhat.com>,
"Warner Losh" <imp@bsdimp.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Ed Maste" <emaste@freebsd.org>,
"Erik Skultety" <eskultet@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Kyle Evans" <kevans@freebsd.org>,
"Li-Wen Hsu" <lwhsu@freebsd.org>,
"Beraldo Leal" <bleal@redhat.com>
Subject: Re: [PATCH v3 2/4] tests/lcitool: Refresh generated files
Date: Tue, 11 Jul 2023 18:58:35 +0100 [thread overview]
Message-ID: <ZK2YS0v5G3iKyXwJ@redhat.com> (raw)
In-Reply-To: <20230711144922.67491-3-philmd@linaro.org>
On Tue, Jul 11, 2023 at 04:49:20PM +0200, Philippe Mathieu-Daudé wrote:
> Refresh the generated files by running:
>
> $ make lcitool-refresh
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> tests/docker/dockerfiles/debian-amd64.docker | 2 -
> tests/docker/dockerfiles/ubuntu2004.docker | 2 -
> tests/docker/dockerfiles/ubuntu2204.docker | 2 -
I don't know why this would be removing xen/pmem from these files. If
I run 'lcitool-refresh' on current git master that doesn't happen
Do you have any other local changes on top ?
> tests/vm/generated/freebsd.json | 77 ++++++++++++++++++++
> 4 files changed, 77 insertions(+), 6 deletions(-)
> create mode 100644 tests/vm/generated/freebsd.json
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>
> diff --git a/tests/docker/dockerfiles/debian-amd64.docker b/tests/docker/dockerfiles/debian-amd64.docker
> index e39871c7bb..8f7521fdc2 100644
> --- a/tests/docker/dockerfiles/debian-amd64.docker
> +++ b/tests/docker/dockerfiles/debian-amd64.docker
> @@ -70,7 +70,6 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
> libpam0g-dev \
> libpcre2-dev \
> libpixman-1-dev \
> - libpmem-dev \
> libpng-dev \
> libpulse-dev \
> librbd-dev \
> @@ -96,7 +95,6 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
> libvdeplug-dev \
> libvirglrenderer-dev \
> libvte-2.91-dev \
> - libxen-dev \
> libzstd-dev \
> llvm \
> locales \
> diff --git a/tests/docker/dockerfiles/ubuntu2004.docker b/tests/docker/dockerfiles/ubuntu2004.docker
> index 8f864d19e6..7f60143cbb 100644
> --- a/tests/docker/dockerfiles/ubuntu2004.docker
> +++ b/tests/docker/dockerfiles/ubuntu2004.docker
> @@ -69,7 +69,6 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
> libpam0g-dev \
> libpcre2-dev \
> libpixman-1-dev \
> - libpmem-dev \
> libpng-dev \
> libpulse-dev \
> librbd-dev \
> @@ -94,7 +93,6 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
> libvdeplug-dev \
> libvirglrenderer-dev \
> libvte-2.91-dev \
> - libxen-dev \
> libzstd-dev \
> llvm \
> locales \
> diff --git a/tests/docker/dockerfiles/ubuntu2204.docker b/tests/docker/dockerfiles/ubuntu2204.docker
> index 1d442cdfe6..5162927016 100644
> --- a/tests/docker/dockerfiles/ubuntu2204.docker
> +++ b/tests/docker/dockerfiles/ubuntu2204.docker
> @@ -70,7 +70,6 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
> libpam0g-dev \
> libpcre2-dev \
> libpixman-1-dev \
> - libpmem-dev \
> libpng-dev \
> libpulse-dev \
> librbd-dev \
> @@ -96,7 +95,6 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
> libvdeplug-dev \
> libvirglrenderer-dev \
> libvte-2.91-dev \
> - libxen-dev \
> libzstd-dev \
> llvm \
> locales \
> diff --git a/tests/vm/generated/freebsd.json b/tests/vm/generated/freebsd.json
> new file mode 100644
> index 0000000000..7c435cf23e
> --- /dev/null
> +++ b/tests/vm/generated/freebsd.json
> @@ -0,0 +1,77 @@
> +{
> + "ccache": "/usr/local/bin/ccache",
> + "cpan_pkgs": [],
> + "cross_pkgs": [],
> + "make": "/usr/local/bin/gmake",
> + "ninja": "/usr/local/bin/ninja",
> + "packaging_command": "pkg",
> + "pip3": "/usr/local/bin/pip-3.8",
> + "pkgs": [
> + "alsa-lib",
> + "bash",
> + "bison",
> + "bzip2",
> + "ca_root_nss",
> + "capstone4",
> + "ccache",
> + "cmocka",
> + "ctags",
> + "curl",
> + "cyrus-sasl",
> + "dbus",
> + "diffutils",
> + "dtc",
> + "flex",
> + "fusefs-libs3",
> + "gettext",
> + "git",
> + "glib",
> + "gmake",
> + "gnutls",
> + "gsed",
> + "gtk3",
> + "json-c",
> + "libepoxy",
> + "libffi",
> + "libgcrypt",
> + "libjpeg-turbo",
> + "libnfs",
> + "libslirp",
> + "libspice-server",
> + "libssh",
> + "libtasn1",
> + "llvm",
> + "lzo2",
> + "meson",
> + "mtools",
> + "ncurses",
> + "nettle",
> + "ninja",
> + "opencv",
> + "pixman",
> + "pkgconf",
> + "png",
> + "py39-numpy",
> + "py39-pillow",
> + "py39-pip",
> + "py39-sphinx",
> + "py39-sphinx_rtd_theme",
> + "py39-yaml",
> + "python3",
> + "rpm2cpio",
> + "sdl2",
> + "sdl2_image",
> + "snappy",
> + "sndio",
> + "socat",
> + "spice-protocol",
> + "tesseract",
> + "usbredir",
> + "virglrenderer",
> + "vte3",
> + "xorriso",
> + "zstd"
> + ],
> + "pypi_pkgs": [],
> + "python": "/usr/local/bin/python3"
> +}
> --
> 2.38.1
>
>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-07-11 17:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 14:49 [PATCH v3 0/4] tests/vm/freebsd: Get up-to-date package list from lcitool Philippe Mathieu-Daudé
2023-07-11 14:49 ` [PATCH v3 1/4] tests/lcitool: Generate distribution packages list in JSON format Philippe Mathieu-Daudé
2023-07-11 15:31 ` Daniel P. Berrangé
2023-07-11 19:39 ` Warner Losh
2023-07-12 11:07 ` Philippe Mathieu-Daudé
2023-07-12 17:57 ` Warner Losh
2023-07-11 14:49 ` [PATCH v3 2/4] tests/lcitool: Refresh generated files Philippe Mathieu-Daudé
2023-07-11 17:58 ` Daniel P. Berrangé [this message]
2023-07-12 11:00 ` Philippe Mathieu-Daudé
2023-07-12 11:12 ` Daniel P. Berrangé
2023-07-12 12:55 ` Philippe Mathieu-Daudé
2023-07-12 13:07 ` Daniel P. Berrangé
2024-01-02 18:19 ` Philippe Mathieu-Daudé
2024-01-02 18:36 ` Ilya Maximets
2024-01-03 9:07 ` Philippe Mathieu-Daudé
2023-07-11 14:49 ` [PATCH v3 3/4] tests/vm: Introduce get_qemu_packages_from_lcitool_json() helper Philippe Mathieu-Daudé
2023-07-11 17:59 ` Daniel P. Berrangé
2023-07-11 14:49 ` [PATCH v3 4/4] tests/vm/freebsd: Get up-to-date package list from lcitool vars file Philippe Mathieu-Daudé
2023-07-11 17:59 ` Daniel P. Berrangé
2023-07-17 12:18 ` [PATCH v3 0/4] tests/vm/freebsd: Get up-to-date package list from lcitool Thomas Huth
2023-07-17 12:30 ` Erik Skultety
2023-07-17 13:17 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZK2YS0v5G3iKyXwJ@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=bleal@redhat.com \
--cc=emaste@freebsd.org \
--cc=eskultet@redhat.com \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=lwhsu@freebsd.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).