From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: "Erik Skultety" <eskultet@redhat.com>,
qemu-devel@nongnu.org, "Thomas Huth" <thuth@redhat.com>,
"Warner Losh" <imp@bsdimp.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Ed Maste" <emaste@freebsd.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Kyle Evans" <kevans@freebsd.org>,
"Li-Wen Hsu" <lwhsu@freebsd.org>,
"Beraldo Leal" <bleal@redhat.com>
Subject: Re: [PATCH v3 2/4] tests/lcitool: Refresh generated files
Date: Wed, 12 Jul 2023 12:12:31 +0100 [thread overview]
Message-ID: <ZK6Kn8hB8soQBRsA@redhat.com> (raw)
In-Reply-To: <41ae7db7-8d80-1749-c89d-025ee30bd73d@linaro.org>
On Wed, Jul 12, 2023 at 01:00:38PM +0200, Philippe Mathieu-Daudé wrote:
> On 11/7/23 19:58, Daniel P. Berrangé wrote:
> > On Tue, Jul 11, 2023 at 04:49:20PM +0200, Philippe Mathieu-Daudé wrote:
> > > Refresh the generated files by running:
> > >
> > > $ make lcitool-refresh
> > >
> > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > > ---
> > > tests/docker/dockerfiles/debian-amd64.docker | 2 -
> > > tests/docker/dockerfiles/ubuntu2004.docker | 2 -
> > > tests/docker/dockerfiles/ubuntu2204.docker | 2 -
> >
> > I don't know why this would be removing xen/pmem from these files. If
> > I run 'lcitool-refresh' on current git master that doesn't happen
> >
> > Do you have any other local changes on top ?
>
> ((887cba855b...))$ make -C build lcitool-refresh
> Generate tests/docker/dockerfiles/alpine.docker
> Generate tests/docker/dockerfiles/centos8.docker
> Generate tests/docker/dockerfiles/debian-amd64.docker
> Generate tests/docker/dockerfiles/fedora.docker
> Generate tests/docker/dockerfiles/opensuse-leap.docker
> Generate tests/docker/dockerfiles/ubuntu2004.docker
> Generate tests/docker/dockerfiles/ubuntu2204.docker
> Generate tests/docker/dockerfiles/debian-amd64-cross.docker
> Generate tests/docker/dockerfiles/debian-arm64-cross.docker
> Generate tests/docker/dockerfiles/debian-armel-cross.docker
> Generate tests/docker/dockerfiles/debian-armhf-cross.docker
> Generate tests/docker/dockerfiles/debian-mips64el-cross.docker
> Generate tests/docker/dockerfiles/debian-mipsel-cross.docker
> Generate tests/docker/dockerfiles/debian-ppc64el-cross.docker
> Generate tests/docker/dockerfiles/debian-riscv64-cross.docker
> Generate tests/docker/dockerfiles/debian-s390x-cross.docker
> Generate tests/docker/dockerfiles/fedora-win32-cross.docker
> Generate tests/docker/dockerfiles/fedora-win64-cross.docker
> Generate .gitlab-ci.d/cirrus/freebsd-13.vars
> Generate .gitlab-ci.d/cirrus/macos-12.vars
> ((887cba855b...))$ git diff -U0
> diff --git a/tests/docker/dockerfiles/debian-amd64.docker
> b/tests/docker/dockerfiles/debian-amd64.docker
> index e39871c7bb..8f7521fdc2 100644
> --- a/tests/docker/dockerfiles/debian-amd64.docker
> +++ b/tests/docker/dockerfiles/debian-amd64.docker
> @@ -73 +72,0 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
> - libpmem-dev \
> @@ -99 +97,0 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
> - libxen-dev \
> diff --git a/tests/docker/dockerfiles/ubuntu2004.docker
> b/tests/docker/dockerfiles/ubuntu2004.docker
> index 8f864d19e6..7f60143cbb 100644
> --- a/tests/docker/dockerfiles/ubuntu2004.docker
> +++ b/tests/docker/dockerfiles/ubuntu2004.docker
> @@ -72 +71,0 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
> - libpmem-dev \
> @@ -97 +95,0 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
> - libxen-dev \
> diff --git a/tests/docker/dockerfiles/ubuntu2204.docker
> b/tests/docker/dockerfiles/ubuntu2204.docker
> index 1d442cdfe6..5162927016 100644
> --- a/tests/docker/dockerfiles/ubuntu2204.docker
> +++ b/tests/docker/dockerfiles/ubuntu2204.docker
> @@ -73 +72,0 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
> - libpmem-dev \
> @@ -99 +97,0 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
> - libxen-dev \
What architecture are you running from ? I'm suspecting it is a non
x86_64 architecture as these pacakges are both arch conditionalized.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-07-12 11:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 14:49 [PATCH v3 0/4] tests/vm/freebsd: Get up-to-date package list from lcitool Philippe Mathieu-Daudé
2023-07-11 14:49 ` [PATCH v3 1/4] tests/lcitool: Generate distribution packages list in JSON format Philippe Mathieu-Daudé
2023-07-11 15:31 ` Daniel P. Berrangé
2023-07-11 19:39 ` Warner Losh
2023-07-12 11:07 ` Philippe Mathieu-Daudé
2023-07-12 17:57 ` Warner Losh
2023-07-11 14:49 ` [PATCH v3 2/4] tests/lcitool: Refresh generated files Philippe Mathieu-Daudé
2023-07-11 17:58 ` Daniel P. Berrangé
2023-07-12 11:00 ` Philippe Mathieu-Daudé
2023-07-12 11:12 ` Daniel P. Berrangé [this message]
2023-07-12 12:55 ` Philippe Mathieu-Daudé
2023-07-12 13:07 ` Daniel P. Berrangé
2024-01-02 18:19 ` Philippe Mathieu-Daudé
2024-01-02 18:36 ` Ilya Maximets
2024-01-03 9:07 ` Philippe Mathieu-Daudé
2023-07-11 14:49 ` [PATCH v3 3/4] tests/vm: Introduce get_qemu_packages_from_lcitool_json() helper Philippe Mathieu-Daudé
2023-07-11 17:59 ` Daniel P. Berrangé
2023-07-11 14:49 ` [PATCH v3 4/4] tests/vm/freebsd: Get up-to-date package list from lcitool vars file Philippe Mathieu-Daudé
2023-07-11 17:59 ` Daniel P. Berrangé
2023-07-17 12:18 ` [PATCH v3 0/4] tests/vm/freebsd: Get up-to-date package list from lcitool Thomas Huth
2023-07-17 12:30 ` Erik Skultety
2023-07-17 13:17 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZK6Kn8hB8soQBRsA@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=bleal@redhat.com \
--cc=emaste@freebsd.org \
--cc=eskultet@redhat.com \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=lwhsu@freebsd.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).