From: Christoph Hellwig <hch@infradead.org>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>, Fam Zheng <fam@euphon.net>,
Thomas Huth <thuth@redhat.com>,
Mark Kanda <mark.kanda@oracle.com>,
linux-scsi@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-stable@nongnu.org, qemu-devel@nongnu.org,
virtualization@lists.linux-foundation.org,
"James E.J. Bottomley" <jejb@linux.ibm.com>
Subject: Re: [PATCH] Revert "virtio-scsi: Send "REPORTED LUNS CHANGED" sense data upon disk hotplug events"
Date: Wed, 12 Jul 2023 06:40:20 -0700 [thread overview]
Message-ID: <ZK6tRDwxgbyYfv2v@infradead.org> (raw)
In-Reply-To: <v6xzholcgdem3c2jkkuhqtmhzo4wflvkh53nohcgtjpgkh5y2e@bb7vliper2f3>
On Wed, Jul 12, 2023 at 10:28:00AM +0200, Stefano Garzarella wrote:
> The problem is that the SCSI stack does not send this command, so we
> should do it in the driver. In fact we do it for
> VIRTIO_SCSI_EVT_RESET_RESCAN (hotplug), but not for
> VIRTIO_SCSI_EVT_RESET_REMOVED (hotunplug).
No, you should absolutely no do it in the driver. The fact that
virtio-scsi even tries to do some of its own LUN scanning is
problematic and should have never happened.
next prev parent reply other threads:[~2023-07-12 13:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 7:15 [PATCH] Revert "virtio-scsi: Send "REPORTED LUNS CHANGED" sense data upon disk hotplug events" Stefano Garzarella
2023-07-05 7:51 ` Thomas Huth
2023-07-05 12:28 ` Mark Kanda
2023-07-05 12:36 ` Stefano Garzarella
2023-07-07 15:57 ` Mark Kanda
2023-07-11 8:12 ` Stefano Garzarella
2023-07-10 19:40 ` Michael S. Tsirkin
2023-07-12 8:12 ` Paolo Bonzini
2023-08-03 20:03 ` Michael S. Tsirkin
2023-07-11 17:06 ` Stefano Garzarella
2023-07-11 17:41 ` Stefan Hajnoczi
2023-07-12 8:28 ` Stefano Garzarella
2023-07-12 13:40 ` Christoph Hellwig [this message]
2023-07-12 14:26 ` Paolo Bonzini
2023-07-11 20:21 ` Mike Christie
2023-07-12 8:06 ` Paolo Bonzini
2023-07-12 10:14 ` Stefano Garzarella
2023-07-12 14:20 ` Stefano Garzarella
2023-07-12 8:35 ` Paolo Bonzini
2023-07-12 10:24 ` Stefano Garzarella
2023-08-03 19:36 ` Michael S. Tsirkin
2023-08-03 19:56 ` Michael S. Tsirkin
2023-08-03 20:02 ` Michael S. Tsirkin
2023-08-03 21:26 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZK6tRDwxgbyYfv2v@infradead.org \
--to=hch@infradead.org \
--cc=fam@euphon.net \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mark.kanda@oracle.com \
--cc=martin.petersen@oracle.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).