From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A738AEB64D9 for ; Wed, 12 Jul 2023 13:41:30 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJa5Z-0008M1-6i; Wed, 12 Jul 2023 09:41:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJa5V-0008Hh-Js; Wed, 12 Jul 2023 09:41:01 -0400 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJa5S-0000me-Uf; Wed, 12 Jul 2023 09:41:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jBtAqtTkPe7xSA8gIcOGPofAG5Ec6Godi3McG+Bj7TI=; b=ne4U33O6PpFN0GLvSBzWvdpMwS fqEB0JUvUajrnCGj0wimrRumDWvNjBni3q3H/klPnnmG4JXWtZNh2Y/Kr8ARlu6T6RA0Yo9YtWZmW VN5KR+qLiAlYcoVi3lgrmu+MPFVYCx1sUWGRxy9IytLpG/Q9I0LQkmPi6tAvlA5H9U2CkWaHcwM8f 9xwHpByfBwJrELoXbx8GycAAGgOUrENgCNm4c5QZcx25O/liCF+a+4efNKt/9ndN5qMe8sUd9Pzr8 9wCz4R6K1OrD+MGsu5s+hBG08OoMrhLMZrhPUZ2QGHJiE6d75hsds9crd8et3iAvcoi5+iwwNPmoT fWOo5qDA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qJa4q-0005Yd-38; Wed, 12 Jul 2023 13:40:20 +0000 Date: Wed, 12 Jul 2023 06:40:20 -0700 From: Christoph Hellwig To: Stefano Garzarella Cc: Stefan Hajnoczi , Paolo Bonzini , Stefan Hajnoczi , Fam Zheng , Thomas Huth , Mark Kanda , linux-scsi@vger.kernel.org, "Martin K. Petersen" , "Michael S. Tsirkin" , qemu-stable@nongnu.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, "James E.J. Bottomley" Subject: Re: [PATCH] Revert "virtio-scsi: Send "REPORTED LUNS CHANGED" sense data upon disk hotplug events" Message-ID: References: <20230705071523.15496-1-sgarzare@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Received-SPF: none client-ip=2607:7c80:54:3::133; envelope-from=BATV+8b06b5fac5f44d4f4265+7262+infradead.org+hch@bombadil.srs.infradead.org; helo=bombadil.infradead.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Jul 12, 2023 at 10:28:00AM +0200, Stefano Garzarella wrote: > The problem is that the SCSI stack does not send this command, so we > should do it in the driver. In fact we do it for > VIRTIO_SCSI_EVT_RESET_RESCAN (hotplug), but not for > VIRTIO_SCSI_EVT_RESET_REMOVED (hotunplug). No, you should absolutely no do it in the driver. The fact that virtio-scsi even tries to do some of its own LUN scanning is problematic and should have never happened.