From: Peter Xu <peterx@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org, "Juan Quintela" <quintela@redhat.com>,
"Steve Sistare" <steven.sistare@oracle.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Leonardo Bras" <leobras@redhat.com>
Subject: Re: [PATCH v3 4/6] migration: Set migration status early in incoming side
Date: Thu, 6 Jul 2023 14:40:17 -0400 [thread overview]
Message-ID: <ZKcKkZ6uSqQnYBqe@x1n> (raw)
In-Reply-To: <20230630212902.19925-5-farosas@suse.de>
On Fri, Jun 30, 2023 at 06:29:00PM -0300, Fabiano Rosas wrote:
> We are sending a migration event of MIGRATION_STATUS_SETUP at
> qemu_start_incoming_migration but never actually setting the state.
>
> This creates a window between qmp_migrate_incoming and
> process_incoming_migration_co where the migration status is still
> MIGRATION_STATUS_NONE. Calling query-migrate during this time will
> return an empty response even though the incoming migration command
> has already been issued.
>
> Commit 7cf1fe6d68 ("migration: Add migration events on target side")
> has added support to the 'events' capability to the incoming part of
> migration, but chose to send the SETUP event without setting the
> state. I'm assuming this was a mistake.
>
> This introduces a change in behavior, any QMP client waiting for the
> SETUP event will hang, unless it has previously enabled the 'events'
> capability. Having the capability enabled is sufficient to continue to
> receive the event.
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2023-07-06 18:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 21:28 [PATCH v3 0/6] migration: Test the new "file:" migration Fabiano Rosas
2023-06-30 21:28 ` [PATCH v3 1/6] tests/qtest: migration: Expose migrate_set_capability Fabiano Rosas
2023-07-06 18:39 ` Peter Xu
2023-06-30 21:28 ` [PATCH v3 2/6] tests/qtest: migration: Add migrate_incoming_qmp helper Fabiano Rosas
2023-07-06 18:38 ` Peter Xu
2023-06-30 21:28 ` [PATCH v3 3/6] tests/qtest: migration: Use migrate_incoming_qmp where appropriate Fabiano Rosas
2023-07-06 18:38 ` Peter Xu
2023-06-30 21:29 ` [PATCH v3 4/6] migration: Set migration status early in incoming side Fabiano Rosas
2023-07-06 18:40 ` Peter Xu [this message]
2023-06-30 21:29 ` [PATCH v3 5/6] tests/qtest: migration: Add support for negative testing of qmp_migrate Fabiano Rosas
2023-07-06 18:49 ` Peter Xu
2023-06-30 21:29 ` [PATCH v3 6/6] tests/qtest: migration-test: Add tests for file-based migration Fabiano Rosas
2023-07-06 18:49 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKcKkZ6uSqQnYBqe@x1n \
--to=peterx@redhat.com \
--cc=berrange@redhat.com \
--cc=farosas@suse.de \
--cc=leobras@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=steven.sistare@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).