From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: Sergii Zasenko <sergii@zasenko.name>, qemu-devel@nongnu.org
Subject: Re: [PATCH] Allow UNIX socket for VNC websocket
Date: Mon, 24 Jul 2023 09:48:39 +0100 [thread overview]
Message-ID: <ZL4654MGVB9ZWXdu@redhat.com> (raw)
In-Reply-To: <CAJ+F1C+_y8APEqWq2fL0DHA3gYLD+wCkwUp+8D1MpARcVfFr_Q@mail.gmail.com>
On Mon, Jul 24, 2023 at 12:08:26PM +0400, Marc-André Lureau wrote:
> Hi
>
> Daniel, in commit 275e0d616b ("ui: refactor code for populating
> SocketAddress from vnc_display_open"), you said "This refactoring also
> removes the restriction that prevents enabling websockets when the plain
> VNC server is listening on a UNIX socket.". But you didn't remove the
> condition. I suppose it was a left-over?
That commit was allowing the regular VNC port to be put on UNIX
socket, at the same time as WS was enabled, it wasn't trying to
put WS on a UNIX socket. Still I seee no reason to keep the
limitation.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-07-24 8:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-23 21:03 [PATCH] Allow UNIX socket for VNC websocket Sergii Zasenko
2023-07-24 8:08 ` Marc-André Lureau
2023-07-24 8:48 ` Daniel P. Berrangé [this message]
2023-07-24 8:49 ` Daniel P. Berrangé
2023-07-24 10:03 ` [PATCH] Allow UNIX socket option " Sergii Zasenko
2023-07-24 10:05 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZL4654MGVB9ZWXdu@redhat.com \
--to=berrange@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=sergii@zasenko.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).