qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Het Gala <het.gala@nutanix.com>
Cc: qemu-devel@nongnu.org, prerna.saxena@nutanix.com,
	quintela@redhat.com, dgilbert@redhat.com, pbonzini@redhat.com,
	armbru@redhat.com, eblake@redhat.com, manish.mishra@nutanix.com,
	aravind.retnakaran@nutanix.com
Subject: Re: [PATCH v8 7/9] migration: modify migration_channels_and_uri_compatible() for new QAPI syntax
Date: Wed, 19 Jul 2023 11:12:19 +0100	[thread overview]
Message-ID: <ZLe3A2dqFxNATnRd@redhat.com> (raw)
In-Reply-To: <20230713105713.236883-8-het.gala@nutanix.com>

On Thu, Jul 13, 2023 at 10:57:11AM +0000, Het Gala wrote:
> migration_channels_and_uri_compatible() check for transport mechanism
> suitable for multifd migration gets executed when the caller calls old
> uri syntax. It needs it to be run when using the modern MigrateChannel
> QAPI syntax too.
> 
> After URI -> 'MigrateChannel' :
> migration_channels_and_uri_compatible() ->
> migration_channels_and_transport_compatible() passes object as argument
> and check for valid transport mechanism.
> 
> Suggested-by: Aravind Retnakaran <aravind.retnakaran@nutanix.com>
> Signed-off-by: Het Gala <het.gala@nutanix.com>
> ---
>  migration/migration.c | 25 ++++++++++++++-----------
>  1 file changed, 14 insertions(+), 11 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2023-07-19 10:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-13 10:57 [PATCH v8 0/9] migration: Modify 'migrate' and 'migrate-incoming' QAPI commands for migration Het Gala
2023-07-13 10:57 ` [PATCH v8 1/9] migration: New QAPI type 'MigrateAddress' Het Gala
2023-07-19  9:51   ` Daniel P. Berrangé
2023-07-13 10:57 ` [PATCH v8 2/9] migration: convert migration 'uri' into 'MigrateAddress' Het Gala
2023-07-19  9:55   ` Daniel P. Berrangé
2023-07-13 10:57 ` [PATCH v8 3/9] migration: convert socket backend to accept MigrateAddress Het Gala
2023-07-19  9:59   ` Daniel P. Berrangé
2023-07-19 15:21   ` Daniel P. Berrangé
2023-07-13 10:57 ` [PATCH v8 4/9] migration: convert rdma " Het Gala
2023-07-19 10:01   ` Daniel P. Berrangé
2023-07-13 10:57 ` [PATCH v8 5/9] migration: convert exec " Het Gala
2023-07-19 10:02   ` Daniel P. Berrangé
2023-07-13 10:57 ` [PATCH v8 6/9] migration: New migrate and migrate-incoming argument 'channels' Het Gala
2023-07-19 10:11   ` Daniel P. Berrangé
2023-07-13 10:57 ` [PATCH v8 7/9] migration: modify migration_channels_and_uri_compatible() for new QAPI syntax Het Gala
2023-07-19 10:12   ` Daniel P. Berrangé [this message]
2023-07-13 10:57 ` [PATCH v8 8/9] migration: Implement MigrateChannelList to migration flow Het Gala
2023-07-19 10:33   ` Daniel P. Berrangé
2023-07-13 10:57 ` [PATCH v8 9/9] migration: Add test case for modified QAPI syntax Het Gala
2023-07-19 10:37   ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZLe3A2dqFxNATnRd@redhat.com \
    --to=berrange@redhat.com \
    --cc=aravind.retnakaran@nutanix.com \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=het.gala@nutanix.com \
    --cc=manish.mishra@nutanix.com \
    --cc=pbonzini@redhat.com \
    --cc=prerna.saxena@nutanix.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).