From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF99FC001DC for ; Mon, 31 Jul 2023 17:25:59 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qQWeH-00009u-NU; Mon, 31 Jul 2023 13:25:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQWeG-00009m-7E for qemu-devel@nongnu.org; Mon, 31 Jul 2023 13:25:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQWeC-000416-VU for qemu-devel@nongnu.org; Mon, 31 Jul 2023 13:25:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690824331; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gVfGik6EnEDxeho7tEDCXJ3DG3m4WPCUrnMIWOsLU8g=; b=MS0ixErcaLpRzdg9c2Sz4gakRpSRDu0ARx1GeI7mufaI48TrokjnCL6gvXWGU8v6T9b6aS jG4WxDyRDRLf7LCp2jpCZBsQfQIgjPFMVpI3297YfRG9gAgZ6gbhwCmyUoCdFBIKsaExnd jZLKKvvn3E5ByUP31CEpwuaiQyG5Hzc= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-477--LmCnhERNvSHQcYT3XZsAQ-1; Mon, 31 Jul 2023 13:25:28 -0400 X-MC-Unique: -LmCnhERNvSHQcYT3XZsAQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C53F43C0ED40; Mon, 31 Jul 2023 17:25:27 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.93]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BEBB640C2063; Mon, 31 Jul 2023 17:25:26 +0000 (UTC) Date: Mon, 31 Jul 2023 18:25:24 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Thomas Huth , Peter Maydell , qemu-devel@nongnu.org, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Stefan Weil , Yonggang Luo Subject: Re: [RFC PATCH 5/6] include/qemu/compiler: Fix problem with gcc_struct and Clang Message-ID: References: <20230728142748.305341-1-thuth@redhat.com> <20230728142748.305341-6-thuth@redhat.com> <6ca265d4-0dad-3725-1cd5-84da685bc63a@redhat.com> <2ff2a91e-6199-045b-c86e-1023e88eb32c@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2ff2a91e-6199-045b-c86e-1023e88eb32c@linaro.org> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Jul 31, 2023 at 04:10:36PM +0200, Philippe Mathieu-Daudé wrote: > On 31/7/23 11:32, Daniel P. Berrangé wrote: > > > I was surprised to see that we're not using ccache in gitlab CI. It wouldn't > > help the from-clean compile time, but thereafter it ought to help. I'm doing > > some tests with that to see the impact. > > I tried that few years ago and this had very negative impact on custom > runners (maybe I wasn't doing it correctly). Hopefully that changed. Our runner usage model has changed since then quite alot. What was previously mostly on shared runners, is now on Azure private runners. I can imagine it will vary tremendously on what you're using as a private runner. In the specific case of the windows jobs though, we're using the shared runners. Either way, if our jobs are all wired up for ccache correctly, it is then trivial to selectively turn off usage of ccache by just tweaking a few env vars. > See some previous comments: > https://lists.nongnu.org/archive/html/qemu-devel/2021-04/msg02220.html > > > Another option might be to try precompiled headers, which meson supports > > quite nicely / transparently. Might especially help on Windows where the > > entire world is declared in windows.h > > > > > > With regards, > > Daniel > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|