From: Zhao Liu <zhao1.liu@linux.intel.com>
To: "Moger, Babu" <babu.moger@amd.com>
Cc: "Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-devel@nongnu.org, "Zhenyu Wang" <zhenyu.z.wang@intel.com>,
"Xiaoyao Li" <xiaoyao.li@intel.com>,
"Zhao Liu" <zhao1.liu@intel.com>,
"Zhuocheng Ding" <zhuocheng.ding@intel.com>
Subject: Re: [PATCH v3 10/17] i386/cpu: Introduce cluster-id to X86CPU
Date: Fri, 4 Aug 2023 17:06:05 +0800 [thread overview]
Message-ID: <ZMy/fTiJf0fDocXv@liuzhao-OptiPlex-7080> (raw)
In-Reply-To: <b7adedcb-e3c8-98b5-6650-91a70790d183@amd.com>
Hi Babu,
On Wed, Aug 02, 2023 at 05:44:38PM -0500, Moger, Babu wrote:
> Date: Wed, 2 Aug 2023 17:44:38 -0500
> From: "Moger, Babu" <babu.moger@amd.com>
> Subject: Re: [PATCH v3 10/17] i386/cpu: Introduce cluster-id to X86CPU
>
> Hi Zhao,
>
> On 8/1/23 05:35, Zhao Liu wrote:
> > From: Zhuocheng Ding <zhuocheng.ding@intel.com>
> >
> > We introduce cluster-id other than module-id to be consistent with
>
> s/We introduce/Introduce/
Thanks! Will fix.
-Zhao
>
> Thanks
> Babu
>
> > CpuInstanceProperties.cluster-id, and this avoids the confusion
> > of parameter names when hotplugging.
> >
> > Following the legacy smp check rules, also add the cluster_id validity
> > into x86_cpu_pre_plug().
> >
> > Signed-off-by: Zhuocheng Ding <zhuocheng.ding@intel.com>
> > Co-developed-by: Zhao Liu <zhao1.liu@intel.com>
> > Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> > Acked-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > hw/i386/x86.c | 33 +++++++++++++++++++++++++--------
> > target/i386/cpu.c | 2 ++
> > target/i386/cpu.h | 1 +
> > 3 files changed, 28 insertions(+), 8 deletions(-)
> >
> > diff --git a/hw/i386/x86.c b/hw/i386/x86.c
> > index 0b460fd6074d..8154b86f95c7 100644
> > --- a/hw/i386/x86.c
> > +++ b/hw/i386/x86.c
> > @@ -328,6 +328,14 @@ void x86_cpu_pre_plug(HotplugHandler *hotplug_dev,
> > cpu->die_id = 0;
> > }
> >
> > + /*
> > + * cluster-id was optional in QEMU 8.0 and older, so keep it optional
> > + * if there's only one cluster per die.
> > + */
> > + if (cpu->cluster_id < 0 && ms->smp.clusters == 1) {
> > + cpu->cluster_id = 0;
> > + }
> > +
> > if (cpu->socket_id < 0) {
> > error_setg(errp, "CPU socket-id is not set");
> > return;
> > @@ -344,6 +352,14 @@ void x86_cpu_pre_plug(HotplugHandler *hotplug_dev,
> > cpu->die_id, ms->smp.dies - 1);
> > return;
> > }
> > + if (cpu->cluster_id < 0) {
> > + error_setg(errp, "CPU cluster-id is not set");
> > + return;
> > + } else if (cpu->cluster_id > ms->smp.clusters - 1) {
> > + error_setg(errp, "Invalid CPU cluster-id: %u must be in range 0:%u",
> > + cpu->cluster_id, ms->smp.clusters - 1);
> > + return;
> > + }
> > if (cpu->core_id < 0) {
> > error_setg(errp, "CPU core-id is not set");
> > return;
> > @@ -363,16 +379,9 @@ void x86_cpu_pre_plug(HotplugHandler *hotplug_dev,
> >
> > topo_ids.pkg_id = cpu->socket_id;
> > topo_ids.die_id = cpu->die_id;
> > + topo_ids.module_id = cpu->cluster_id;
> > topo_ids.core_id = cpu->core_id;
> > topo_ids.smt_id = cpu->thread_id;
> > -
> > - /*
> > - * TODO: This is the temporary initialization for topo_ids.module_id to
> > - * avoid "maybe-uninitialized" compilation errors. Will remove when
> > - * X86CPU supports cluster_id.
> > - */
> > - topo_ids.module_id = 0;
> > -
> > cpu->apic_id = x86_apicid_from_topo_ids(&topo_info, &topo_ids);
> > }
> >
> > @@ -419,6 +428,14 @@ void x86_cpu_pre_plug(HotplugHandler *hotplug_dev,
> > }
> > cpu->die_id = topo_ids.die_id;
> >
> > + if (cpu->cluster_id != -1 && cpu->cluster_id != topo_ids.module_id) {
> > + error_setg(errp, "property cluster-id: %u doesn't match set apic-id:"
> > + " 0x%x (cluster-id: %u)", cpu->cluster_id, cpu->apic_id,
> > + topo_ids.module_id);
> > + return;
> > + }
> > + cpu->cluster_id = topo_ids.module_id;
> > +
> > if (cpu->core_id != -1 && cpu->core_id != topo_ids.core_id) {
> > error_setg(errp, "property core-id: %u doesn't match set apic-id:"
> > " 0x%x (core-id: %u)", cpu->core_id, cpu->apic_id,
> > diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> > index d6969813ee02..ffa282219078 100644
> > --- a/target/i386/cpu.c
> > +++ b/target/i386/cpu.c
> > @@ -7806,12 +7806,14 @@ static Property x86_cpu_properties[] = {
> > DEFINE_PROP_UINT32("apic-id", X86CPU, apic_id, 0),
> > DEFINE_PROP_INT32("thread-id", X86CPU, thread_id, 0),
> > DEFINE_PROP_INT32("core-id", X86CPU, core_id, 0),
> > + DEFINE_PROP_INT32("cluster-id", X86CPU, cluster_id, 0),
> > DEFINE_PROP_INT32("die-id", X86CPU, die_id, 0),
> > DEFINE_PROP_INT32("socket-id", X86CPU, socket_id, 0),
> > #else
> > DEFINE_PROP_UINT32("apic-id", X86CPU, apic_id, UNASSIGNED_APIC_ID),
> > DEFINE_PROP_INT32("thread-id", X86CPU, thread_id, -1),
> > DEFINE_PROP_INT32("core-id", X86CPU, core_id, -1),
> > + DEFINE_PROP_INT32("cluster-id", X86CPU, cluster_id, -1),
> > DEFINE_PROP_INT32("die-id", X86CPU, die_id, -1),
> > DEFINE_PROP_INT32("socket-id", X86CPU, socket_id, -1),
> > #endif
> > diff --git a/target/i386/cpu.h b/target/i386/cpu.h
> > index 5e97d0b76574..d9577938ae04 100644
> > --- a/target/i386/cpu.h
> > +++ b/target/i386/cpu.h
> > @@ -2034,6 +2034,7 @@ struct ArchCPU {
> > int32_t node_id; /* NUMA node this CPU belongs to */
> > int32_t socket_id;
> > int32_t die_id;
> > + int32_t cluster_id;
> > int32_t core_id;
> > int32_t thread_id;
> >
>
> --
> Thanks
> Babu Moger
next prev parent reply other threads:[~2023-08-04 8:56 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 10:35 [PATCH v3 00/17] Support smp.clusters for x86 Zhao Liu
2023-08-01 10:35 ` [PATCH v3 01/17] i386: Fix comment style in topology.h Zhao Liu
2023-08-01 23:13 ` Moger, Babu
2023-08-04 8:12 ` Zhao Liu
2023-08-07 2:16 ` Xiaoyao Li
2023-08-07 7:05 ` Zhao Liu
2023-08-01 10:35 ` [PATCH v3 02/17] tests: Rename test-x86-cpuid.c to test-x86-topo.c Zhao Liu
2023-08-01 23:20 ` Moger, Babu
2023-08-04 8:14 ` Zhao Liu
2023-08-01 10:35 ` [PATCH v3 03/17] softmmu: Fix CPUSTATE.nr_cores' calculation Zhao Liu
2023-08-02 15:25 ` Moger, Babu
2023-08-04 8:16 ` Zhao Liu
2023-08-07 7:03 ` Xiaoyao Li
2023-08-07 7:53 ` Zhao Liu
2023-08-07 8:43 ` Xiaoyao Li
2023-08-07 10:00 ` Zhao Liu
2023-08-07 14:20 ` Xiaoyao Li
2023-08-07 14:42 ` Zhao Liu
2023-08-01 10:35 ` [PATCH v3 04/17] i386/cpu: Fix i/d-cache topology to core level for Intel CPU Zhao Liu
2023-08-04 9:56 ` Xiaoyao Li
2023-08-04 12:43 ` Zhao Liu
2023-08-01 10:35 ` [PATCH v3 05/17] i386/cpu: Use APIC ID offset to encode cache topo in CPUID[4] Zhao Liu
2023-08-02 15:41 ` Moger, Babu
2023-08-04 8:21 ` Zhao Liu
2023-08-07 8:13 ` Xiaoyao Li
2023-08-07 9:30 ` Zhao Liu
2023-08-01 10:35 ` [PATCH v3 06/17] i386/cpu: Consolidate the use of topo_info in cpu_x86_cpuid() Zhao Liu
2023-08-02 16:31 ` Moger, Babu
2023-08-04 8:23 ` Zhao Liu
2023-08-01 10:35 ` [PATCH v3 07/17] i386: Introduce module-level cpu topology to CPUX86State Zhao Liu
2023-08-01 10:35 ` [PATCH v3 08/17] i386: Support modules_per_die in X86CPUTopoInfo Zhao Liu
2023-08-02 17:25 ` Moger, Babu
2023-08-04 9:05 ` Zhao Liu
2023-08-01 10:35 ` [PATCH v3 09/17] i386: Support module_id in X86CPUTopoIDs Zhao Liu
2023-08-01 10:35 ` [PATCH v3 10/17] i386/cpu: Introduce cluster-id to X86CPU Zhao Liu
2023-08-02 22:44 ` Moger, Babu
2023-08-04 9:06 ` Zhao Liu [this message]
2023-08-01 10:35 ` [PATCH v3 11/17] tests: Add test case of APIC ID for module level parsing Zhao Liu
2023-08-01 10:35 ` [PATCH v3 12/17] hw/i386/pc: Support smp.clusters for x86 PC machine Zhao Liu
2023-08-01 10:35 ` [PATCH v3 13/17] i386: Add cache topology info in CPUCacheInfo Zhao Liu
2023-08-01 10:35 ` [PATCH v3 14/17] i386: Use CPUCacheInfo.share_level to encode CPUID[4] Zhao Liu
2023-08-02 23:49 ` Moger, Babu
2023-08-03 16:41 ` Moger, Babu
2023-08-04 9:48 ` Zhao Liu
2023-08-04 15:48 ` Moger, Babu
2023-08-14 8:22 ` Zhao Liu
2023-08-14 16:03 ` Moger, Babu
2023-08-18 7:37 ` Zhao Liu
2023-08-23 17:18 ` Moger, Babu
2023-09-01 8:43 ` Zhao Liu
2023-08-01 10:35 ` [PATCH v3 15/17] i386: Fix NumSharingCache for CPUID[0x8000001D].EAX[bits 25:14] Zhao Liu
2023-08-03 20:40 ` Moger, Babu
2023-08-04 9:50 ` Zhao Liu
2023-08-01 10:35 ` [PATCH v3 16/17] i386: Use CPUCacheInfo.share_level to encode " Zhao Liu
2023-08-03 20:44 ` Moger, Babu
2023-08-04 9:56 ` Zhao Liu
2023-08-04 18:50 ` Moger, Babu
2023-08-01 10:35 ` [PATCH v3 17/17] i386: Add new property to control L2 cache topo in CPUID.04H Zhao Liu
2023-08-01 15:35 ` [PATCH v3 00/17] Support smp.clusters for x86 Jonathan Cameron via
2023-08-04 13:17 ` Zhao Liu
2023-08-08 11:52 ` Jonathan Cameron via
2023-08-01 23:11 ` Moger, Babu
2023-08-04 7:44 ` Zhao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMy/fTiJf0fDocXv@liuzhao-OptiPlex-7080 \
--to=zhao1.liu@linux.intel.com \
--cc=babu.moger@amd.com \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=wangyanan55@huawei.com \
--cc=xiaoyao.li@intel.com \
--cc=zhao1.liu@intel.com \
--cc=zhenyu.z.wang@intel.com \
--cc=zhuocheng.ding@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).