qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Fiona Ebner <f.ebner@proxmox.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, hreitz@redhat.com,
	thuth@redhat.com, t.lamprecht@proxmox.com, qemu-block@nongnu.org
Subject: Re: [PATCH] iotests: adapt test output for new qemu_cleanup() behavior
Date: Fri, 18 Aug 2023 16:56:41 +0200	[thread overview]
Message-ID: <ZN+GqbebcMSE11SW@redhat.com> (raw)
In-Reply-To: <20230817112538.255111-1-f.ebner@proxmox.com>

Am 17.08.2023 um 13:25 hat Fiona Ebner geschrieben:
> Since commit ca2a5e630d ("qemu_cleanup: begin drained section after
> vm_shutdown()"), there will be an additional pause for jobs during
> qemu_cleanup(). The reason is that the bdrv_drain_all() call in
> do_vm_stop() is not inside the drained section used by qemu_cleanup()
> anymore. I.e., there is a second drained section now that ends before
> the final one in qemu_cleanup() starts. Thus, job_pause() is called
> twice during cleanup (via child_job_drained_begin()).
> 
> Test 185 needs to be adapted directly too, because it waits for a
> specific number of JOB_STATUS_CHANGE events before the
> BLOCK_JOB_CANCELLED event.
> 
> Reported-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>

Thanks, applied to the block branch.

Kevin



      reply	other threads:[~2023-08-18 14:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-17 11:25 [PATCH] iotests: adapt test output for new qemu_cleanup() behavior Fiona Ebner
2023-08-18 14:56 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZN+GqbebcMSE11SW@redhat.com \
    --to=kwolf@redhat.com \
    --cc=f.ebner@proxmox.com \
    --cc=hreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=t.lamprecht@proxmox.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).