From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3DB0CC73C66 for ; Fri, 18 Aug 2023 15:36:22 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qX1WM-0003sA-4B; Fri, 18 Aug 2023 11:36:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qX1WL-0003rf-Gl for qemu-devel@nongnu.org; Fri, 18 Aug 2023 11:36:17 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qX1WJ-0006YN-A1 for qemu-devel@nongnu.org; Fri, 18 Aug 2023 11:36:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692372974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=J8h1tttFDxqEWc/RC2h7PhLMSmn/0iiazO510DoEYFg=; b=PlbxYqzmJRZg9kpYg/0MxcRFqLiIf9jw0CKZ8ftyCCNYRYRt8ZTQGk0FOKMN5Rsz9dQP+9 wfiEDVylDYVj++mPI3Hr5eytLyO1ZhN1iOvPr02j/EaTTZv4TnEaqd+CsArHYensg2lXVC Z5ZCasLX2TrUQVMODqzenw9CSQMLn4g= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-453-7VzaXOc6OZac3Uxk3FfQTA-1; Fri, 18 Aug 2023 11:36:12 -0400 X-MC-Unique: 7VzaXOc6OZac3Uxk3FfQTA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 35F921C07560; Fri, 18 Aug 2023 15:36:12 +0000 (UTC) Received: from redhat.com (unknown [10.39.192.160]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5DA5C2166B2D; Fri, 18 Aug 2023 15:36:11 +0000 (UTC) Date: Fri, 18 Aug 2023 17:36:10 +0200 From: Kevin Wolf To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Fam Zheng , qemu-block@nongnu.org, Hanna Reitz Subject: Re: [PATCH 0/2] block: change reqs_lock to QemuMutex Message-ID: References: <20230808155852.2745350-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230808155852.2745350-1-stefanha@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Received-SPF: pass client-ip=170.10.129.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Am 08.08.2023 um 17:58 hat Stefan Hajnoczi geschrieben: > As part of the ongoing multi-queue QEMU block layer work, I found that CoMutex > reqs_lock scales poorly when more IOThreads are added. These patches double > IOPS in the 4 IOThreads randread benchmark that I have been running with my > out-of-tree virtio-blk-iothread-vq-mapping branch > (https://gitlab.com/stefanha/qemu/-/commits/virtio-blk-iothread-vq-mapping). > > These patches can be merged in preparation for virtio-blk multi-queue block > layer support. Thanks, applied to the block branch. Kevin