From: Kevin Wolf <kwolf@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
Hanna Reitz <hreitz@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [PATCH trivial] qemu-img: omit errno value in error message
Date: Fri, 18 Aug 2023 17:39:29 +0200 [thread overview]
Message-ID: <ZN+QsRrUmIQRR7v8@redhat.com> (raw)
In-Reply-To: <20230811110946.2435067-1-mjt@tls.msk.ru>
Am 11.08.2023 um 13:09 hat Michael Tokarev geschrieben:
> I'm getting io-qcow2-244 test failure on mips*
> due to output mismatch:
>
> Take an internal snapshot:
> -qemu-img: Could not create snapshot 'test': -95 (Operation not supported)
> +qemu-img: Could not create snapshot 'test': -122 (Operation not supported)
> No errors were found on the image.
>
> This is because errno values might be different across
> different architectures.
>
> This error message in qemu-img.c is the only one which
> prints errno directly, all the rest print strerror(errno)
> only. Fix this error message and the expected output
> of the 3 test cases too.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2023-08-18 15:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 11:09 [PATCH trivial] qemu-img: omit errno value in error message Michael Tokarev
2023-08-18 15:39 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZN+QsRrUmIQRR7v8@redhat.com \
--to=kwolf@redhat.com \
--cc=hreitz@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).