From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1497C73C66 for ; Fri, 18 Aug 2023 15:40:14 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qX1Zf-00075b-1s; Fri, 18 Aug 2023 11:39:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qX1Za-00071s-Ca for qemu-devel@nongnu.org; Fri, 18 Aug 2023 11:39:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qX1ZY-0006y5-CC for qemu-devel@nongnu.org; Fri, 18 Aug 2023 11:39:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692373175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VnOAnR1mAHey59wJJe5lzj4SidLujLRF9gak9OXwuiA=; b=WpHU266PV+2EWYTdEsmKzXqWBH0tMtg2ZWEQgdDDcS/TQP5/fU7tanFdsjFtvE5VY3T9pb 0c0cqb5SoYwSgDbgCvkCx05vtSfS1obs+eMFAO62fF+xzC3H+i/LWT7hVRh3cJgEk1JMo0 GxtApUr5wUYq6JFZyXv6nRee9q/yzDE= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-518-IgCJD-IgPe6WER5HwqDXfg-1; Fri, 18 Aug 2023 11:39:32 -0400 X-MC-Unique: IgCJD-IgPe6WER5HwqDXfg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3B5763C0FCA6; Fri, 18 Aug 2023 15:39:32 +0000 (UTC) Received: from redhat.com (unknown [10.39.192.160]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 691632026D68; Fri, 18 Aug 2023 15:39:30 +0000 (UTC) Date: Fri, 18 Aug 2023 17:39:29 +0200 From: Kevin Wolf To: Michael Tokarev Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, Hanna Reitz , qemu-block@nongnu.org Subject: Re: [PATCH trivial] qemu-img: omit errno value in error message Message-ID: References: <20230811110946.2435067-1-mjt@tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230811110946.2435067-1-mjt@tls.msk.ru> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Am 11.08.2023 um 13:09 hat Michael Tokarev geschrieben: > I'm getting io-qcow2-244 test failure on mips* > due to output mismatch: > > Take an internal snapshot: > -qemu-img: Could not create snapshot 'test': -95 (Operation not supported) > +qemu-img: Could not create snapshot 'test': -122 (Operation not supported) > No errors were found on the image. > > This is because errno values might be different across > different architectures. > > This error message in qemu-img.c is the only one which > prints errno directly, all the rest print strerror(errno) > only. Fix this error message and the expected output > of the 3 test cases too. > > Signed-off-by: Michael Tokarev Thanks, applied to the block branch. Kevin