From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 186EEC2FC0E for ; Thu, 17 Aug 2023 10:27:51 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWaDg-0000mv-TF; Thu, 17 Aug 2023 06:27:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWaDf-0000hy-IV for qemu-devel@nongnu.org; Thu, 17 Aug 2023 06:27:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWaDd-0007If-23 for qemu-devel@nongnu.org; Thu, 17 Aug 2023 06:27:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692268026; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=nIPu240JcSWhwdnv/5OXdU8PtOjF6gbjrMOTfXcAHeU=; b=CAHeDB8is3H2VLRysMcXzvHQZkcdq0w9iRIdpzTxgtczE45W2YNyb0wam/QHlaRB2ZO9jE ErHtns9QwnsZWas+L6EMgrocWXVh9YaoLMCPSPfIz5rixWt0wntyngsUUf56HtnFNpefau WS8NaGyBQzqZ/6Fgfsk9GOpy0765GOI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-621-l4xCIgsqMHOIdTnwJXLscA-1; Thu, 17 Aug 2023 06:27:00 -0400 X-MC-Unique: l4xCIgsqMHOIdTnwJXLscA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 79B2285CCE7; Thu, 17 Aug 2023 10:27:00 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.120]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9F2B7140E950; Thu, 17 Aug 2023 10:26:59 +0000 (UTC) Date: Thu, 17 Aug 2023 11:26:57 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Efim Shevrin Cc: qemu-devel@nongnu.org, kkostiuk@redhat.com, michael.roth@amd.com, pbonzini@redhat.com, den@openvz.org Subject: Re: [PATCH] qga: Start qemu-ga service after NetworkManager start Message-ID: References: <20230816200446.1408797-1-efim.shevrin@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230816200446.1408797-1-efim.shevrin@virtuozzo.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Aug 17, 2023 at 04:04:46AM +0800, Efim Shevrin via wrote: > From: Fima Shevrin > > When the guest OS starts, qemu-ga sends an event to the host. > This event allows services on the host to start configuring > the already running guest OS. When configuring network settings, > it is possible that an external service will receive a signal > from qemu-ga about the start of guest OS, while NetworkManager > may not be running yet. Therefore, network setting may not > be available. With the current patch, we eliminate the described > race condition between qemu-ga and NetworkManager for guest OS > network setting cases. A host mgmt app should not be assuming that networking is running at all, and if it is, the guest might not even be on the same subnet as the host. Conceivably someone could even be using QGA to inject files to configure networking. Overall, IMHO, it is wrong to correlate host notification that QGA is running, with any assumption about state of the guest networking. IOW, I don't think we should make an attempt to serialize startup of QGA after guest networking. The QGA should be run as soon as its data transport (virtio-serial/vsock) is available, which is the current state. If a host consumer of QGA wants to do something with guest networking, they should check for guest network state with the 'guest-network-get-interfaces' command. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|