From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Leonardo Bras Soares Passos <lsoaresp@redhat.com>,
Fabiano Rosas <farosas@suse.de>,
Juan Quintela <quintela@redhat.com>,
qemu-stable@nongnu.org
Subject: Re: [PATCH for-8.2 1/4] migration/qmp: Fix crash on setting tls-authz with null
Date: Thu, 17 Aug 2023 14:14:11 +0100 [thread overview]
Message-ID: <ZN4dI8HqCSbX3dm9@redhat.com> (raw)
In-Reply-To: <20230814221947.353093-2-peterx@redhat.com>
On Mon, Aug 14, 2023 at 06:19:44PM -0400, Peter Xu wrote:
> QEMU will crash if anyone tries to set tls-authz (which is a type
> StrOrNull) with 'null' value. Fix it in the easy way by converting it to
> qstring just like the other two tls parameters.
>
> Cc: qemu-stable@nongnu.org # v4.0+
> Fixes: d2f1d29b95 ("migration: add support for a "tls-authz" migration parameter")
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> migration/options.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-08-17 13:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 22:19 [PATCH for-8.2 0/4] qapi/migration: Dedup migration parameter objects and fix tls-authz crash Peter Xu
2023-08-14 22:19 ` [PATCH for-8.2 1/4] migration/qmp: Fix crash on setting tls-authz with null Peter Xu
2023-08-15 12:47 ` Fabiano Rosas
2023-08-17 13:14 ` Daniel P. Berrangé [this message]
2023-08-14 22:19 ` [PATCH for-8.2 2/4] tests/migration-test: Add a test for null parameter setups Peter Xu
2023-08-15 12:46 ` Fabiano Rosas
2023-08-14 22:19 ` [PATCH for-8.2 3/4] migration/qapi: Replace @MigrateSetParameters with @MigrationParameters Peter Xu
2023-08-23 13:26 ` Markus Armbruster
2023-08-23 15:52 ` Peter Xu
2023-08-25 17:14 ` Peter Xu
2023-08-14 22:19 ` [PATCH for-8.2 4/4] migration/qapi: Drop @MigrationParameter enum Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZN4dI8HqCSbX3dm9@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=farosas@suse.de \
--cc=lsoaresp@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).