From: Peter Xu <peterx@redhat.com>
To: Guoyi Tu <tugy@chinatelecom.cn>
Cc: "【外部账号】 Fabiano Rosas" <farosas@suse.de>,
"Juan Quintela" <quintela@redhat.com>,
"Leonardo Bras" <leobras@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] migrate/ram: let ram_save_target_page_legacy() return if qemu file got error
Date: Thu, 17 Aug 2023 09:35:38 -0400 [thread overview]
Message-ID: <ZN4iKgeVeLBSCSK2@x1n> (raw)
In-Reply-To: <15874e41-fee0-49db-98fc-cf2b545fe7c2@chinatelecom.cn>
On Thu, Aug 17, 2023 at 10:19:19AM +0800, Guoyi Tu wrote:
>
>
> On 2023/8/16 23:15, 【外部账号】 Fabiano Rosas wrote:
> > Peter Xu <peterx@redhat.com> writes:
> >
> > > On Tue, Aug 15, 2023 at 07:42:24PM -0300, Fabiano Rosas wrote:
> > > > Yep, I see that. I meant explicitly move the code into the loop. Feels a
> > > > bit weird to check the QEMUFile for errors first thing inside the
> > > > function when nothing around it should have touched the QEMUFile.
> > >
> > > Valid point. This reminded me that now we have one indirection into
> > > ->ram_save_target_page() which is a hook now. Putting in the caller will
> > > work for all hooks, even though they're not yet exist.
> > >
> > > But since we don't have any other hooks yet, it'll be the same for now
Guoyi,
Your email got cut from here. Same thing happened on emails from Hyman
(also sent from China Telecom email address), maybe your mail system did
something wrong.
--
Peter Xu
next prev parent reply other threads:[~2023-08-17 13:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 7:21 [PATCH] migrate/ram: let ram_save_target_page_legacy() return if qemu file got error Guoyi Tu
2023-08-15 12:35 ` Fabiano Rosas
2023-08-15 22:19 ` Peter Xu
2023-08-15 22:42 ` Fabiano Rosas
2023-08-16 14:48 ` Peter Xu
2023-08-16 15:15 ` Fabiano Rosas
2023-08-17 2:19 ` Guoyi Tu
2023-08-17 13:35 ` Peter Xu [this message]
2023-08-17 14:29 ` Guoyi Tu
2023-08-17 14:32 ` Guoyi Tu
2023-08-16 2:09 ` Guoyi Tu
[not found] ` <1289281636.5044.1692148361356.JavaMail.root@jt-retransmission-dep-56f978df86-2gmr2>
2023-08-16 2:01 ` Guoyi Tu
2023-08-16 12:18 ` Fabiano Rosas
2023-09-04 11:55 ` Guoyi Tu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZN4iKgeVeLBSCSK2@x1n \
--to=peterx@redhat.com \
--cc=farosas@suse.de \
--cc=leobras@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=tugy@chinatelecom.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).