qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: gudkov.andrei@huawei.com
Cc: Yong Huang <yong.huang@smartx.com>,
	qemu-devel@nongnu.org, quintela@redhat.com, leobras@redhat.com,
	eblake@redhat.com, armbru@redhat.com
Subject: Re: [PATCH v2] migration/calc-dirty-rate: millisecond-granularity period
Date: Wed, 9 Aug 2023 11:26:16 -0400	[thread overview]
Message-ID: <ZNOwGBybcBz0DpH7@x1n> (raw)
In-Reply-To: <ZNOqnLFaD/At4poY@DESKTOP-0LHM7NF.china.huawei.com>

On Wed, Aug 09, 2023 at 06:02:52PM +0300, gudkov.andrei@huawei.com wrote:
> > Not for the patch, I'm just curious about how the predication
> > decides the network throughput, I mean QEMU predicts
> > if migration will converge based on how fast it sends the data,
> > not the actual bandwidth of the interface, which one the
> > prediction uses?
> > 
> Currently I use network nominal bandwidth, e.g. 1gbps. It would
> be nice, of course, to use measured throughput since it can take
> into account network headers overhead (as Wang Lei previously
> mentioned), compression, etc., but it looks too complicated to
> implement outside of migration process.

Using line speed is definitely wise, but qemu may be stupid enough to do
wrong calculations and when it happens migration may not switchover..

See this:

https://lore.kernel.org/r/20230803155344.11450-3-peterx@redhat.com

Probably should be used together with your ways of prediction to be even
more accurate on some workloads where mbps reports insane numbers.

Thanks,

-- 
Peter Xu



  reply	other threads:[~2023-08-09 15:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-04 15:03 [PATCH v2] migration/calc-dirty-rate: millisecond-granularity period Andrei Gudkov via
2023-08-04 16:14 ` Peter Xu
2023-08-04 18:04 ` Markus Armbruster
2023-08-06  6:31   ` Yong Huang
2023-08-09 13:59     ` gudkov.andrei--- via
2023-08-10  6:37       ` Yong Huang
2023-08-06  6:16 ` Yong Huang
2023-08-09 15:02   ` gudkov.andrei--- via
2023-08-09 15:26     ` Peter Xu [this message]
2023-08-10  6:39     ` Yong Huang
2023-08-26  8:32     ` Yong Huang
2023-08-28  6:23       ` gudkov.andrei--- via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZNOwGBybcBz0DpH7@x1n \
    --to=peterx@redhat.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=gudkov.andrei@huawei.com \
    --cc=leobras@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=yong.huang@smartx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).