From: Peter Xu <peterx@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: ThinerLogoer <logoerthiner1@163.com>,
qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v1 1/3] softmmu/physmem: fallback to opening guest RAM file as readonly in a MAP_PRIVATE mapping
Date: Fri, 11 Aug 2023 12:22:30 -0400 [thread overview]
Message-ID: <ZNZgRq22IXyqpun7@x1n> (raw)
In-Reply-To: <e07f29a3-482a-3fcb-7aff-c88827c41385@redhat.com>
On Fri, Aug 11, 2023 at 06:17:05PM +0200, David Hildenbrand wrote:
> We wouldn't touch "-mem-path".
But still the same issue when someone uses -object memory-backend-file for
hugetlb, mapping privately, expecting ram discard to work?
Basically I see that example as, "hugetlb" in general made the private
mapping over RW file usable, so forbidden that anywhere may take a risk.
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2023-08-11 16:22 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 19:07 [PATCH v1 0/3] softmmu/physmem: file_ram_open() readonly improvements David Hildenbrand
2023-08-07 19:07 ` [PATCH v1 1/3] softmmu/physmem: fallback to opening guest RAM file as readonly in a MAP_PRIVATE mapping David Hildenbrand
2023-08-08 21:01 ` Peter Xu
2023-08-09 5:39 ` ThinerLogoer
2023-08-09 9:20 ` David Hildenbrand
2023-08-09 15:15 ` Peter Xu
2023-08-10 14:19 ` David Hildenbrand
2023-08-10 17:06 ` ThinerLogoer
2023-08-10 21:24 ` Peter Xu
2023-08-11 5:49 ` ThinerLogoer
2023-08-11 14:31 ` Peter Xu
2023-08-12 6:21 ` ThinerLogoer
2023-08-22 13:35 ` David Hildenbrand
2023-08-11 19:00 ` David Hildenbrand
2023-08-12 5:18 ` ThinerLogoer
2023-08-17 9:07 ` David Hildenbrand
2023-08-17 14:30 ` David Hildenbrand
2023-08-17 14:37 ` Daniel P. Berrangé
2023-08-17 14:37 ` David Hildenbrand
2023-08-17 14:45 ` Daniel P. Berrangé
2023-08-17 14:47 ` David Hildenbrand
2023-08-17 14:41 ` Peter Xu
2023-08-17 15:02 ` David Hildenbrand
2023-08-17 15:13 ` Stefan Hajnoczi
2023-08-17 15:15 ` David Hildenbrand
2023-08-17 15:25 ` David Hildenbrand
2023-08-17 15:31 ` Peter Xu
2023-08-17 15:43 ` David Hildenbrand
2023-08-17 13:46 ` Daniel P. Berrangé
2023-08-17 13:48 ` David Hildenbrand
2023-08-11 14:59 ` David Hildenbrand
2023-08-11 15:26 ` David Hildenbrand
2023-08-11 16:16 ` Peter Xu
2023-08-11 16:17 ` David Hildenbrand
2023-08-11 16:22 ` Peter Xu [this message]
2023-08-11 16:25 ` David Hildenbrand
2023-08-11 16:54 ` Peter Xu
2023-08-11 17:39 ` David Hildenbrand
2023-08-11 21:07 ` Peter Xu
2023-08-21 12:20 ` Igor Mammedov
2023-08-11 15:47 ` Peter Xu
2023-08-17 13:42 ` Daniel P. Berrangé
2023-08-17 13:45 ` David Hildenbrand
2023-08-17 13:37 ` Daniel P. Berrangé
2023-08-17 13:44 ` David Hildenbrand
2023-08-07 19:07 ` [PATCH v1 2/3] softmmu/physmem: fail creation of new files in file_ram_open() with readonly=true David Hildenbrand
2023-08-07 19:07 ` [PATCH v1 3/3] softmmu/physmem: never return directories from file_ram_open() David Hildenbrand
2023-08-08 17:26 ` Re:[PATCH v1 0/3] softmmu/physmem: file_ram_open() readonly improvements ThinerLogoer
2023-08-10 11:11 ` [PATCH " Philippe Mathieu-Daudé
2023-08-10 16:35 ` ThinerLogoer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNZgRq22IXyqpun7@x1n \
--to=peterx@redhat.com \
--cc=david@redhat.com \
--cc=imammedo@redhat.com \
--cc=logoerthiner1@163.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).