From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, Fabiano Rosas <farosas@suse.de>,
Leonardo Bras Soares Passos <lsoaresp@redhat.com>,
Juan Quintela <quintela@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH v2 4/4] migration/qapi: Drop @MigrationParameter enum
Date: Tue, 29 Aug 2023 12:51:19 +0100 [thread overview]
Message-ID: <ZO3bt0FkPqfECpA0@redhat.com> (raw)
In-Reply-To: <20230825171517.1215317-5-peterx@redhat.com>
On Fri, Aug 25, 2023 at 01:15:17PM -0400, Peter Xu wrote:
> Drop the enum in qapi because it is never used in QMP APIs. Instead making
> it an internal definition for QEMU so that we can decouple it from QAPI,
> and also we can deduplicate the QAPI documentations.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> qapi/migration.json | 179 ---------------------------------
> migration/options.h | 47 +++++++++
> migration/migration-hmp-cmds.c | 3 +-
> migration/options.c | 51 ++++++++++
> 4 files changed, 100 insertions(+), 180 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2023-08-29 11:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 17:15 [PATCH v2 0/4] qapi/migration: Dedup migration parameter objects and fix tls-authz crash Peter Xu
2023-08-25 17:15 ` [PATCH v2 1/4] migration/qmp: Fix crash on setting tls-authz with null Peter Xu
2023-08-29 14:12 ` Philippe Mathieu-Daudé
2023-08-25 17:15 ` [PATCH v2 2/4] tests/migration-test: Add a test for null parameter setups Peter Xu
2023-08-25 17:33 ` Thomas Huth
2023-08-25 20:57 ` Peter Xu
2023-08-29 14:12 ` Philippe Mathieu-Daudé
2023-08-25 17:15 ` [PATCH v2 3/4] migration/qapi: Replace @MigrateSetParameters with @MigrationParameters Peter Xu
2023-08-29 11:49 ` Daniel P. Berrangé
2023-08-25 17:15 ` [PATCH v2 4/4] migration/qapi: Drop @MigrationParameter enum Peter Xu
2023-08-29 11:51 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZO3bt0FkPqfECpA0@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=farosas@suse.de \
--cc=lsoaresp@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).