qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 06/10] contrib/plugins: use an independent makefile
Date: Tue, 29 Aug 2023 18:16:16 +0100	[thread overview]
Message-ID: <ZO4n4BWt2+D7dZh+@redhat.com> (raw)
In-Reply-To: <20230829082931.67601-7-pbonzini@redhat.com>

On Tue, Aug 29, 2023 at 10:29:27AM +0200, Paolo Bonzini wrote:
> The initial reason to write this patch was to remove the last use of
> CONFIG_DEBUG_TCG from the makefiles; the flags to use to build TCG
> plugins are unrelated to --enable-debug-tcg, and instead they should
> be the same as those used to build emulators (the plugins are not build
> via meson for demonstration reasons only).
> 
> However, since contrib/plugins/Makefile is also the last case of doing
> a compilation job using config-host.mak, go a step further and make it
> use a completely separate configuration file, removing all references
> to compilers from the toplevel config-host.mak.  Clean up references to
> empty variables, and use .SECONDARY so that intermediate object files
> are not deleted.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  configure                | 12 +++++++++---
>  contrib/plugins/Makefile | 18 +++++++++---------
>  2 files changed, 18 insertions(+), 12 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2023-08-29 17:16 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-29  8:29 [PATCH 00/10] configure cleanups for QEMU 8.2 Paolo Bonzini
2023-08-29  8:29 ` [PATCH 01/10] meson: do not unnecessarily use cmake for dependencies Paolo Bonzini
2023-08-29 17:14   ` Daniel P. Berrangé
2023-08-29  8:29 ` [PATCH 02/10] meson: update unsupported host/CPU messages Paolo Bonzini
2023-08-29 10:34   ` Daniel P. Berrangé
2023-08-31  8:20     ` Paolo Bonzini
2023-08-31  8:51       ` Daniel P. Berrangé
2023-08-29  8:29 ` [PATCH 03/10] configure: remove HOST_CC Paolo Bonzini
2023-08-29 17:12   ` Daniel P. Berrangé
2023-08-29 18:40   ` Richard Henderson
2023-08-29  8:29 ` [PATCH 04/10] configure: create native file with contents of $host_cc Paolo Bonzini
2023-08-29 16:54   ` Peter Maydell
2023-08-29 17:14   ` Daniel P. Berrangé
2023-08-31  8:26     ` Paolo Bonzini
2023-08-29 18:45   ` Richard Henderson
2023-08-29  8:29 ` [PATCH 05/10] meson: compile bundled device trees Paolo Bonzini
2023-08-29 14:25   ` Philippe Mathieu-Daudé
2023-08-29 18:48     ` Richard Henderson
2023-08-29 18:47   ` Richard Henderson
2023-08-29  8:29 ` [PATCH 06/10] contrib/plugins: use an independent makefile Paolo Bonzini
2023-08-29 17:16   ` Daniel P. Berrangé [this message]
2023-08-29  8:29 ` [PATCH 07/10] meson: do not use config_host to pick tap implementations Paolo Bonzini
2023-08-29 14:26   ` Philippe Mathieu-Daudé
2023-08-29 17:05   ` Daniel P. Berrangé
2023-08-29  8:29 ` [PATCH 08/10] configure, meson: move simple OS definitions to meson Paolo Bonzini
2023-08-29 14:28   ` Philippe Mathieu-Daudé
2023-08-29  8:29 ` [PATCH 09/10] configure: remove $linux and $mingw32 variables Paolo Bonzini
2023-08-29 14:28   ` Philippe Mathieu-Daudé
2023-08-29 17:05   ` Daniel P. Berrangé
2023-08-29  8:29 ` [PATCH 10/10] configure: move --enable-debug-tcg to meson Paolo Bonzini
2023-08-29 16:57   ` Peter Maydell
2023-08-29 18:52   ` Richard Henderson
2023-08-31  8:17   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZO4n4BWt2+D7dZh+@redhat.com \
    --to=berrange@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).