From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1AB9FC6FA8F for ; Tue, 29 Aug 2023 17:16:49 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qb2KJ-0003dJ-MU; Tue, 29 Aug 2023 13:16:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qb2KH-0003d1-Bt for qemu-devel@nongnu.org; Tue, 29 Aug 2023 13:16:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qb2KE-00081z-Tp for qemu-devel@nongnu.org; Tue, 29 Aug 2023 13:16:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693329382; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gmuNP5WmhsT5Vqt5eau46b/ENSHSgHdMgVAFM2pCW3M=; b=R8856wJcvGLWo8s4JpRc0twSzxklqEbq86SxSKv08GnRx4J3CXUJL57EsNrJJO/LbYQX2F xNEZv6A13uVR364sUTGpkDmOtJ7lK0KMFRxC5T1jy7OKw/Xeh5bjWueHGmkjuKxM5GKSQk dDv+yKs66nqpA3Vr0dU0fvfDUiFpYVU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-582-Y-jvYn2RO6Wo8yyR7NAvBg-1; Tue, 29 Aug 2023 13:16:19 -0400 X-MC-Unique: Y-jvYn2RO6Wo8yyR7NAvBg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1368F806006 for ; Tue, 29 Aug 2023 17:16:19 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.52]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9210D2166B25; Tue, 29 Aug 2023 17:16:18 +0000 (UTC) Date: Tue, 29 Aug 2023 18:16:16 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Paolo Bonzini Cc: qemu-devel@nongnu.org Subject: Re: [PATCH 06/10] contrib/plugins: use an independent makefile Message-ID: References: <20230829082931.67601-1-pbonzini@redhat.com> <20230829082931.67601-7-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230829082931.67601-7-pbonzini@redhat.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Aug 29, 2023 at 10:29:27AM +0200, Paolo Bonzini wrote: > The initial reason to write this patch was to remove the last use of > CONFIG_DEBUG_TCG from the makefiles; the flags to use to build TCG > plugins are unrelated to --enable-debug-tcg, and instead they should > be the same as those used to build emulators (the plugins are not build > via meson for demonstration reasons only). > > However, since contrib/plugins/Makefile is also the last case of doing > a compilation job using config-host.mak, go a step further and make it > use a completely separate configuration file, removing all references > to compilers from the toplevel config-host.mak. Clean up references to > empty variables, and use .SECONDARY so that intermediate object files > are not deleted. > > Signed-off-by: Paolo Bonzini > --- > configure | 12 +++++++++--- > contrib/plugins/Makefile | 18 +++++++++--------- > 2 files changed, 18 insertions(+), 12 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|