* [PATCH] kconfig: Add NVME to s390x machines
@ 2023-08-28 15:01 Cédric Le Goater
2023-08-28 18:16 ` Thomas Huth
2023-08-30 6:56 ` Klaus Jensen
0 siblings, 2 replies; 3+ messages in thread
From: Cédric Le Goater @ 2023-08-28 15:01 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-s390x, Thomas Huth, Paolo Bonzini, Klaus Jensen,
Cédric Le Goater
From: Cédric Le Goater <clg@redhat.com>
We recently had issues with nvme devices on big endian platforms.
Include their compilation on s390x to ease tests.
Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
hw/nvme/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/nvme/Kconfig b/hw/nvme/Kconfig
index 8ac90942e55e..cfa2ab0f9d5a 100644
--- a/hw/nvme/Kconfig
+++ b/hw/nvme/Kconfig
@@ -1,4 +1,4 @@
config NVME_PCI
bool
- default y if PCI_DEVICES
+ default y if PCI_DEVICES || PCIE_DEVICES
depends on PCI
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] kconfig: Add NVME to s390x machines
2023-08-28 15:01 [PATCH] kconfig: Add NVME to s390x machines Cédric Le Goater
@ 2023-08-28 18:16 ` Thomas Huth
2023-08-30 6:56 ` Klaus Jensen
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2023-08-28 18:16 UTC (permalink / raw)
To: Cédric Le Goater, qemu-devel
Cc: qemu-s390x, Paolo Bonzini, Klaus Jensen, Cédric Le Goater,
QEMU Trivial
On 28/08/2023 17.01, Cédric Le Goater wrote:
> From: Cédric Le Goater <clg@redhat.com>
>
> We recently had issues with nvme devices on big endian platforms.
> Include their compilation on s390x to ease tests.
>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
> hw/nvme/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/nvme/Kconfig b/hw/nvme/Kconfig
> index 8ac90942e55e..cfa2ab0f9d5a 100644
> --- a/hw/nvme/Kconfig
> +++ b/hw/nvme/Kconfig
> @@ -1,4 +1,4 @@
> config NVME_PCI
> bool
> - default y if PCI_DEVICES
> + default y if PCI_DEVICES || PCIE_DEVICES
> depends on PCI
hw/nvme/ctrl.c uses INTERFACE_PCIE_DEVICE, so I think looks right to me.
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kconfig: Add NVME to s390x machines
2023-08-28 15:01 [PATCH] kconfig: Add NVME to s390x machines Cédric Le Goater
2023-08-28 18:16 ` Thomas Huth
@ 2023-08-30 6:56 ` Klaus Jensen
1 sibling, 0 replies; 3+ messages in thread
From: Klaus Jensen @ 2023-08-30 6:56 UTC (permalink / raw)
To: Cédric Le Goater
Cc: qemu-devel, qemu-s390x, Thomas Huth, Paolo Bonzini,
Cédric Le Goater
[-- Attachment #1: Type: text/plain, Size: 728 bytes --]
On Aug 28 17:01, Cédric Le Goater wrote:
> From: Cédric Le Goater <clg@redhat.com>
>
> We recently had issues with nvme devices on big endian platforms.
> Include their compilation on s390x to ease tests.
>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
> hw/nvme/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/nvme/Kconfig b/hw/nvme/Kconfig
> index 8ac90942e55e..cfa2ab0f9d5a 100644
> --- a/hw/nvme/Kconfig
> +++ b/hw/nvme/Kconfig
> @@ -1,4 +1,4 @@
> config NVME_PCI
> bool
> - default y if PCI_DEVICES
> + default y if PCI_DEVICES || PCIE_DEVICES
> depends on PCI
> --
> 2.41.0
>
Acked-by: Klaus Jensen <k.jensen@samsung.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-30 6:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-28 15:01 [PATCH] kconfig: Add NVME to s390x machines Cédric Le Goater
2023-08-28 18:16 ` Thomas Huth
2023-08-30 6:56 ` Klaus Jensen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).