qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V4 00/11] fix migration of suspended runstate
@ 2023-08-29 18:17 Steve Sistare
  2023-08-29 18:17 ` [PATCH V4 01/11] cpus: pass runstate to vm_prepare_start Steve Sistare
                   ` (10 more replies)
  0 siblings, 11 replies; 27+ messages in thread
From: Steve Sistare @ 2023-08-29 18:17 UTC (permalink / raw)
  To: qemu-devel
  Cc: Juan Quintela, Peter Xu, Paolo Bonzini, Thomas Huth,
	Daniel P. Berrangé, Steve Sistare

Migration of a guest in the suspended runstate is broken.  The incoming
migration code automatically tries to wake the guest, which is wrong;
the guest should end migration in the same runstate it started.  Further,
for a restored snapshot, the automatic wakeup fails.  The runstate is
RUNNING, but the guest is not.  See the commit messages for the details.

Changes in V2:
  * simplify "start on wakeup request"
  * fix postcopy, snapshot, and background migration
  * refactor fixes for each type of migration
  * explicitly handled suspended events and runstate in tests
  * add test for postcopy and background migration

Changes in V3:
  * rebase to tip
  * fix hang in new function migrate_wait_for_dirty_mem

Changes in V4:
  * rebase to tip
  * add patch for vm_prepare_start (thanks Peter)
  * add patch to preserve cpu ticks

Steve Sistare (11):
  cpus: pass runstate to vm_prepare_start
  migration: preserve suspended runstate
  migration: add runstate function
  migration: preserve suspended for snapshot
  migration: preserve suspended for bg_migration
  migration: preserve cpu ticks if suspended
  tests/qtest: migration events
  tests/qtest: option to suspend during migration
  tests/qtest: precopy migration with suspend
  tests/qtest: postcopy migration with suspend
  tests/qtest: background migration with suspend

 backends/tpm/tpm_emulator.c          |   2 +-
 gdbstub/softmmu.c                    |   2 +-
 hw/usb/hcd-ehci.c                    |   2 +-
 hw/usb/redirect.c                    |   2 +-
 hw/xen/xen-hvm-common.c              |   2 +-
 include/sysemu/runstate.h            |   3 +-
 migration/migration.c                |  49 +++++-----
 migration/migration.h                |   1 +
 migration/savevm.c                   |   9 +-
 softmmu/cpu-timers.c                 |  36 ++++++-
 softmmu/cpus.c                       |   8 +-
 softmmu/runstate.c                   |   3 +
 tests/migration/i386/Makefile        |   5 +-
 tests/migration/i386/a-b-bootblock.S |  51 +++++++++-
 tests/migration/i386/a-b-bootblock.h |  22 +++--
 tests/qtest/migration-helpers.c      |  27 ++----
 tests/qtest/migration-helpers.h      |   9 +-
 tests/qtest/migration-test.c         | 178 +++++++++++++++++++++++++++--------
 18 files changed, 299 insertions(+), 112 deletions(-)

-- 
1.8.3.1



^ permalink raw reply	[flat|nested] 27+ messages in thread

end of thread, other threads:[~2023-11-13 19:22 UTC | newest]

Thread overview: 27+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-29 18:17 [PATCH V4 00/11] fix migration of suspended runstate Steve Sistare
2023-08-29 18:17 ` [PATCH V4 01/11] cpus: pass runstate to vm_prepare_start Steve Sistare
2023-08-30 15:52   ` Peter Xu
2023-08-30 15:56     ` Steven Sistare
2023-08-29 18:17 ` [PATCH V4 02/11] migration: preserve suspended runstate Steve Sistare
2023-08-30 16:07   ` Peter Xu
2023-08-29 18:17 ` [PATCH V4 03/11] migration: add runstate function Steve Sistare
2023-08-30 16:11   ` Peter Xu
2023-08-29 18:17 ` [PATCH V4 04/11] migration: preserve suspended for snapshot Steve Sistare
2023-08-30 16:22   ` Peter Xu
2023-11-13 18:32     ` Steven Sistare
2023-08-29 18:18 ` [PATCH V4 05/11] migration: preserve suspended for bg_migration Steve Sistare
2023-08-30 16:35   ` Peter Xu
2023-11-13 18:32     ` Steven Sistare
2023-08-29 18:18 ` [PATCH V4 06/11] migration: preserve cpu ticks if suspended Steve Sistare
2023-08-30 16:47   ` Peter Xu
2023-09-07 15:50     ` Steven Sistare
2023-11-13 18:32     ` Steven Sistare
2023-08-29 18:18 ` [PATCH V4 07/11] tests/qtest: migration events Steve Sistare
2023-08-30 17:00   ` Peter Xu
2023-11-13 18:33     ` Steven Sistare
2023-11-13 19:20       ` Steven Sistare
2023-08-29 18:18 ` [PATCH V4 08/11] tests/qtest: option to suspend during migration Steve Sistare
2023-08-30 17:01   ` Peter Xu
2023-08-29 18:18 ` [PATCH V4 09/11] tests/qtest: precopy migration with suspend Steve Sistare
2023-08-29 18:18 ` [PATCH V4 10/11] tests/qtest: postcopy " Steve Sistare
2023-08-29 18:18 ` [PATCH V4 11/11] tests/qtest: background " Steve Sistare

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).