From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85E7FEE49A5 for ; Mon, 21 Aug 2023 08:28:45 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qY0Ge-0004MK-J0; Mon, 21 Aug 2023 04:28:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qY0GV-0004Ls-69 for qemu-devel@nongnu.org; Mon, 21 Aug 2023 04:28:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qY0GS-0000cT-03 for qemu-devel@nongnu.org; Mon, 21 Aug 2023 04:27:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692606473; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=dDjls7+ILiWbqhXYks55zfDhfY7DM1MGCD/3Cd5UPU8=; b=B4gj1GvvsjbSj6Crq+L/c2vm198i2TbhdCSLWhRq+kPfPuRqbLfRuZqPsVtTNrnoNtWjFs lYsOqItPA4k2yS6qiGVN7H34zEjhdCtEodCFspYlCtUye0Axk9313tShDTk1JJHxRkhrq1 nvYgyZVxvNzcYH6zSkYLOdST38K23D4= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-478-vR_qHInePkKdzT03Xem86g-1; Mon, 21 Aug 2023 04:27:49 -0400 X-MC-Unique: vR_qHInePkKdzT03Xem86g-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CE0BF3C02B66; Mon, 21 Aug 2023 08:27:48 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.139]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2E4DF63F6C; Mon, 21 Aug 2023 08:27:45 +0000 (UTC) Date: Mon, 21 Aug 2023 09:27:43 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Xiaoyao Li Cc: Paolo Bonzini , Richard Henderson , "Michael S. Tsirkin" , Marcel Apfelbaum , Igor Mammedov , Ani Sinha , Peter Xu , David Hildenbrand , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Cornelia Huck , Eric Blake , Markus Armbruster , Marcelo Tosatti , Gerd Hoffmann , qemu-devel@nongnu.org, kvm@vger.kernel.org, Eduardo Habkost , Laszlo Ersek , Isaku Yamahata , erdemaktas@google.com, Chenyi Qiang Subject: Re: [PATCH v2 03/58] target/i386: Parse TDX vm type Message-ID: References: <20230818095041.1973309-1-xiaoyao.li@intel.com> <20230818095041.1973309-4-xiaoyao.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230818095041.1973309-4-xiaoyao.li@intel.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Aug 18, 2023 at 05:49:46AM -0400, Xiaoyao Li wrote: > TDX VM requires VM type KVM_X86_TDX_VM to be passed to > kvm_ioctl(KVM_CREATE_VM). > > If tdx-guest object is specified to confidential-guest-support, like, > > qemu -machine ...,confidential-guest-support=tdx0 \ > -object tdx-guest,id=tdx0,... > > it parses VM type as KVM_X86_TDX_VM. > > Signed-off-by: Xiaoyao Li > --- > target/i386/kvm/kvm.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c > index 62f237068a3a..77f4772afe6c 100644 > --- a/target/i386/kvm/kvm.c > +++ b/target/i386/kvm/kvm.c > @@ -32,6 +32,7 @@ > #include "sysemu/runstate.h" > #include "kvm_i386.h" > #include "sev.h" > +#include "tdx.h" > #include "xen-emu.h" > #include "hyperv.h" > #include "hyperv-proto.h" > @@ -158,6 +159,7 @@ static int kvm_get_one_msr(X86CPU *cpu, int index, uint64_t *value); > static const char* vm_type_name[] = { > [KVM_X86_DEFAULT_VM] = "default", > [KVM_X86_SW_PROTECTED_VM] = "sw-protected-vm", > + [KVM_X86_TDX_VM] = "tdx", > }; > > int kvm_get_vm_type(MachineState *ms, const char *vm_type) > @@ -170,12 +172,18 @@ int kvm_get_vm_type(MachineState *ms, const char *vm_type) > kvm_type = KVM_X86_DEFAULT_VM; > } else if (!g_ascii_strcasecmp(vm_type, "sw-protected-vm")) { > kvm_type = KVM_X86_SW_PROTECTED_VM; > - } else { > + } else if (!g_ascii_strcasecmp(vm_type, "tdx")) { > + kvm_type = KVM_X86_TDX_VM; > + }else { > error_report("Unknown kvm-type specified '%s'", vm_type); > exit(1); > } > } This whole block of code should go away - as this should not exist as a user visible property. It should be sufficient to use the tdx-guest object type to identify use of TDX. > > + if (ms->cgs && object_dynamic_cast(OBJECT(ms->cgs), TYPE_TDX_GUEST)) { > + kvm_type = KVM_X86_TDX_VM; > + } > + > /* > * old KVM doesn't support KVM_CAP_VM_TYPES and KVM_X86_DEFAULT_VM > * is always supported > -- > 2.34.1 > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|