From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C65BEE4996 for ; Mon, 21 Aug 2023 09:40:47 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qY1Of-0000jp-KR; Mon, 21 Aug 2023 05:40:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qY1Oe-0000jY-0c for qemu-devel@nongnu.org; Mon, 21 Aug 2023 05:40:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qY1Ob-0006wA-J8 for qemu-devel@nongnu.org; Mon, 21 Aug 2023 05:40:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692610824; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=RsDe2yoAX8jvqHcrEjQ1brMmtnocoQMptpe4iQxCeu0=; b=JHKBGPnKmcVjbzZz6rt/oZhFNQcsmHPIL/aZCIWyJO5hPk8dEh2DiHSRnTIDfk7PPHtjwU otsdjvo+HKe8Fe/hyYwFoklmLCbR+h31RvKdVToA6dz6Bsh2SAv02APmKx8RTNlvx1GN6u qgf5MMBt0/ZM9Zh1uo/J79Sm93ky7YU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-481-_7fBnyyNOJiUC5U7lomUMg-1; Mon, 21 Aug 2023 05:40:20 -0400 X-MC-Unique: _7fBnyyNOJiUC5U7lomUMg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C41078DC666; Mon, 21 Aug 2023 09:40:19 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.139]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 236F8492C13; Mon, 21 Aug 2023 09:40:17 +0000 (UTC) Date: Mon, 21 Aug 2023 10:40:15 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Xiaoyao Li Cc: Paolo Bonzini , Richard Henderson , "Michael S. Tsirkin" , Marcel Apfelbaum , Igor Mammedov , Ani Sinha , Peter Xu , David Hildenbrand , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Cornelia Huck , Eric Blake , Markus Armbruster , Marcelo Tosatti , Gerd Hoffmann , qemu-devel@nongnu.org, kvm@vger.kernel.org, Eduardo Habkost , Laszlo Ersek , Isaku Yamahata , erdemaktas@google.com, Chenyi Qiang Subject: Re: [PATCH v2 36/58] memory: Introduce memory_region_init_ram_gmem() Message-ID: References: <20230818095041.1973309-1-xiaoyao.li@intel.com> <20230818095041.1973309-37-xiaoyao.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230818095041.1973309-37-xiaoyao.li@intel.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Aug 18, 2023 at 05:50:19AM -0400, Xiaoyao Li wrote: > Introduce memory_region_init_ram_gmem() to allocate private gmem on the > MemoryRegion initialization. It's for the usercase of TDVF, which must > be private on TDX case. > > Signed-off-by: Xiaoyao Li > --- > include/exec/memory.h | 6 +++++ > softmmu/memory.c | 52 +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 58 insertions(+) > diff --git a/softmmu/memory.c b/softmmu/memory.c > index af6aa3c1e3c9..ded44dcef1aa 100644 > --- a/softmmu/memory.c > +++ b/softmmu/memory.c > @@ -25,6 +25,7 @@ > #include "qom/object.h" > #include "trace.h" > > +#include > #include "exec/memory-internal.h" > #include "exec/ram_addr.h" > #include "sysemu/kvm.h" > @@ -3602,6 +3603,57 @@ void memory_region_init_ram(MemoryRegion *mr, > vmstate_register_ram(mr, owner_dev); > } > > +#ifdef CONFIG_KVM > +void memory_region_init_ram_gmem(MemoryRegion *mr, > + Object *owner, > + const char *name, > + uint64_t size, > + Error **errp) Since you have an 'errp' parameter here.... > +{ > + DeviceState *owner_dev; > + Error *err = NULL; > + int priv_fd; > + > + memory_region_init_ram_nomigrate(mr, owner, name, size, &err); > + if (err) { > + error_propagate(errp, err); > + return; > + } > + > + if (object_dynamic_cast(OBJECT(current_accel()), TYPE_KVM_ACCEL)) { > + KVMState *s = KVM_STATE(current_accel()); > + struct kvm_create_guest_memfd gmem = { > + .size = size, > + /* TODO: add property to hostmem backend for huge pmd */ > + .flags = KVM_GUEST_MEMFD_ALLOW_HUGEPAGE, > + }; > + > + priv_fd = kvm_vm_ioctl(s, KVM_CREATE_GUEST_MEMFD, &gmem); > + if (priv_fd < 0) { > + fprintf(stderr, "%s: error creating gmem: %s\n", __func__, > + strerror(-priv_fd)); > + abort(); It should be using error_setg_errno() here and return not abort > + } > + } else { > + fprintf(stderr, "%s: gmem unsupported accel: %s\n", __func__, > + current_accel_name()); and error_setg() here and return. > + abort(); > + } > + > + memory_region_set_gmem_fd(mr, priv_fd); > + memory_region_set_default_private(mr); > + > + /* This will assert if owner is neither NULL nor a DeviceState. > + * We only want the owner here for the purposes of defining a > + * unique name for migration. TODO: Ideally we should implement > + * a naming scheme for Objects which are not DeviceStates, in > + * which case we can relax this restriction. > + */ > + owner_dev = DEVICE(owner); > + vmstate_register_ram(mr, owner_dev); > +} > +#endif > + > void memory_region_init_rom(MemoryRegion *mr, > Object *owner, > const char *name, > -- > 2.34.1 > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|