qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Levon <john.levon@nutanix.com>
To: William Henderson <william.henderson@nutanix.com>
Cc: qemu-devel@nongnu.org, alex.williamson@redhat.com,
	clg@redhat.com, jag.raman@oracle.com, philmd@linaro.org,
	stefanha@gmail.com, thanos.makatos@nutanix.com
Subject: Re: [RFC PATCH v2 1/1] vfio-user: add live migration to vfio-user protocol specification
Date: Wed, 23 Aug 2023 15:00:17 +0100	[thread overview]
Message-ID: <ZOYQ8TuJKCRnSpeR@movementarian.org> (raw)
In-Reply-To: <20230823100400.152847-2-william.henderson@nutanix.com>

On Wed, Aug 23, 2023 at 10:04:00AM +0000, William Henderson wrote:

> +* *argsz* is the size of the above structure.

As we discussed offline, this isn't right for any of these. They have the same
->argsz semantics as discussed here:

https://github.com/nutanix/libvfio-user/blob/master/docs/vfio-user.rst#message-sizes

So this value should in fact be the (max) size of the reply message.

regards
john


      reply	other threads:[~2023-08-23 14:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-23 10:03 [RFC PATCH v2 0/1] vfio-user: add live migration to vfio-user protocol specification William Henderson
2023-08-23 10:04 ` [RFC PATCH v2 1/1] " William Henderson
2023-08-23 14:00   ` John Levon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZOYQ8TuJKCRnSpeR@movementarian.org \
    --to=john.levon@nutanix.com \
    --cc=alex.williamson@redhat.com \
    --cc=clg@redhat.com \
    --cc=jag.raman@oracle.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=thanos.makatos@nutanix.com \
    --cc=william.henderson@nutanix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).