From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B04D0C3DA66 for ; Wed, 23 Aug 2023 20:22:42 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qYuMZ-0005CG-KI; Wed, 23 Aug 2023 16:21:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qYuMX-000533-MH for qemu-devel@nongnu.org; Wed, 23 Aug 2023 16:21:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qYuMW-0005DN-Ah for qemu-devel@nongnu.org; Wed, 23 Aug 2023 16:21:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692822115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OZUUI9OuJikA+Ni22WO2mMugGOnErdZK+bc8iYyX1q8=; b=CQYF/ze+h+FxgwtLwUDAqFfRGwllOXws9VFO+7z3v3/6h/jzXTtVZuOxyOhXcQo2pwTszh yH2rtI5K6hMl85iOSbFot9jGCC+B2dVRrjOvC9ARmHr5EQ4gIrdFw6gYOyHj5JNQPQ83GT kwLQMb5FWIWPG5DvNXPTTpkGdmRs/Yw= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-581-JVoWyNO1MJyu-Eym1J5zWw-1; Wed, 23 Aug 2023 16:21:54 -0400 X-MC-Unique: JVoWyNO1MJyu-Eym1J5zWw-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-64d08acfd16so13465776d6.1 for ; Wed, 23 Aug 2023 13:21:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692822114; x=1693426914; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OZUUI9OuJikA+Ni22WO2mMugGOnErdZK+bc8iYyX1q8=; b=Q79kInLKBYetEPjPUzUwPBraSil4JbwesClfArcgGwwVLgz9u3f+x6ycq9V6GyvmkN rgJjo9/51jhoo3Ba1liBmLo4FuDPJcu/OXOSskqTfDNKb+rL99OYYXdiuEL45YEDKZ0i EcVzwAJsdtcs2+RNQ89mFH8zyy4D8JRiu4H5KlyDF0lhM1fihiKL8UisstcXSKWN+Vte g4HKZk/xG2phaEsCBpkaJDDQ/as/t/J3bD0wpENFWanz5hcL7vGzp5ee0wrvrKudQDTa AFa/xlpPShb025Bqmog5kESMPokbKXm5YSPM/rldKUbysFN0U497u+BW++xL/TKOQxfn JsEQ== X-Gm-Message-State: AOJu0Yzm8KN2MLzKJDQ6dzTkMVibJvYrX0DJeB3fbC/NPXbTU+7IXM3J QXd5C5MVC9bmIbcmLQkOdwKpqB3GpbtbYoAl1efC7YnqyBWpsLlgiiWwjHTWec/OPs+yBD9VxEz ZOZEjDESqYPYazHg= X-Received: by 2002:a05:6214:4017:b0:63f:64ba:a30a with SMTP id kd23-20020a056214401700b0063f64baa30amr15536031qvb.2.1692822113934; Wed, 23 Aug 2023 13:21:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE8tgUv1dSbyVgcYuz3MY3iOcRnWWac0uRH3hlmAzO/Hv1FLcinM/Z8dRB+ea4w/A0VAo5LnQ== X-Received: by 2002:a05:6214:4017:b0:63f:64ba:a30a with SMTP id kd23-20020a056214401700b0063f64baa30amr15536015qvb.2.1692822113721; Wed, 23 Aug 2023 13:21:53 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id u16-20020a0cb410000000b0063d588c4111sm4849964qve.82.2023.08.23.13.21.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Aug 2023 13:21:53 -0700 (PDT) Date: Wed, 23 Aug 2023 16:21:51 -0400 From: Peter Xu To: David Hildenbrand Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, Paolo Bonzini , Igor Mammedov , Thiner Logoer , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Daniel P =?utf-8?B?LiBCZXJyYW5nw6k=?= , Stefan Hajnoczi , Elena Ufimtseva , Jagannathan Raman , "Michael S. Tsirkin" , Ani Sinha , Xiao Guangrong , Daniel Henrique Barboza , Greg Kurz , Eric Blake , Markus Armbruster , Eduardo Habkost Subject: Re: [PATCH v3 05/11] softmmu/physmem: Bail out early in ram_block_discard_range() with readonly files Message-ID: References: <20230823153412.832081-1-david@redhat.com> <20230823153412.832081-6-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230823153412.832081-6-david@redhat.com> Received-SPF: pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Aug 23, 2023 at 05:34:05PM +0200, David Hildenbrand wrote: > fallocate() will fail, let's print a nicer error message. > > Suggested-by: Peter Xu > Signed-off-by: David Hildenbrand Reviewed-by: Peter Xu -- Peter Xu