From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Victor Toso <victortoso@redhat.com>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
John Snow <jsnow@redhat.com>
Subject: Re: [PATCH v2 09/11] qapi: fix example of query-blockstats command
Date: Mon, 11 Sep 2023 11:55:39 +0100 [thread overview]
Message-ID: <ZP7yK5pu14z3guXe@redhat.com> (raw)
In-Reply-To: <20230911104017.65397-10-victortoso@redhat.com>
On Mon, Sep 11, 2023 at 12:40:17PM +0200, Victor Toso wrote:
> Example output has several missing commas. Add them.
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> ---
> qapi/block-core.json | 32 ++++++++++++++++----------------
> 1 file changed, 16 insertions(+), 16 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-09-11 10:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 10:40 [PATCH v2 00/11] Validate and test qapi examples Victor Toso
2023-09-11 10:40 ` [PATCH v2 01/11] qapi: fix example of get-win32-socket command Victor Toso
2023-09-11 10:40 ` [PATCH v2 02/11] qapi: fix example of dumpdtb command Victor Toso
2023-09-11 10:40 ` [PATCH v2 03/11] qapi: fix example of cancel-vcpu-dirty-limit command Victor Toso
2023-09-11 10:40 ` [PATCH v2 04/11] qapi: fix example of set-vcpu-dirty-limit command Victor Toso
2023-09-11 10:40 ` [PATCH v2 05/11] qapi: fix example of calc-dirty-rate command Victor Toso
2023-09-11 10:40 ` [PATCH v2 06/11] qapi: fix example of NETDEV_STREAM_CONNECTED event Victor Toso
2023-09-11 10:40 ` [PATCH v2 07/11] qapi: fix example of query-rocker-of-dpa-flows command Victor Toso
2023-09-11 10:53 ` Daniel P. Berrangé
2023-09-14 13:50 ` Markus Armbruster
2023-09-14 14:01 ` Victor Toso
2023-09-14 14:15 ` Daniel P. Berrangé
2023-09-11 10:40 ` [PATCH v2 08/11] qapi: fix example of query-spice command Victor Toso
2023-09-11 10:53 ` Daniel P. Berrangé
2023-09-11 10:40 ` [PATCH v2 09/11] qapi: fix example of query-blockstats command Victor Toso
2023-09-11 10:55 ` Daniel P. Berrangé [this message]
2023-09-11 11:27 ` [PATCH v2 10/11] qapi: meson: add test flag to allow skip generators Victor Toso
2023-09-11 11:27 ` [PATCH v2 11/11] qapi: scripts: add a generator for qapi's examples Victor Toso
2023-09-14 13:51 ` [PATCH v2 00/11] Validate and test qapi examples Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZP7yK5pu14z3guXe@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=victortoso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).