From: Kevin Wolf <kwolf@redhat.com>
To: Dmitry Frolov <frolov@swemel.ru>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, fam@euphon.net,
hreitz@redhat.com, sdl.qemu@linuxtesting.org
Subject: Re: [PATCH] fix bdrv_open_child return value check
Date: Fri, 1 Sep 2023 13:15:40 +0200 [thread overview]
Message-ID: <ZPHH3N8RiMxNa13F@redhat.com> (raw)
In-Reply-To: <20230831125926.796205-1-frolov@swemel.ru>
Am 31.08.2023 um 14:59 hat Dmitry Frolov geschrieben:
> bdrv_open_child() may return NULL.
> Usually return value is checked for this function.
> Check for return value is more reliable.
>
> Fixes: 24bc15d1f6 ("vmdk: Use BdrvChild instead of BDS for references to extents")
>
> Signed-off-by: Dmitry Frolov <frolov@swemel.ru>
Did you actually see some failure because of this? If so, what is the
specific case that failed?
Or is this just cleanup based on code inspection?
Kevin
next prev parent reply other threads:[~2023-09-01 11:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 12:59 [PATCH] fix bdrv_open_child return value check Dmitry Frolov
2023-09-01 11:15 ` Kevin Wolf [this message]
2023-09-01 11:26 ` Дмитрий Фролов
2023-09-01 13:57 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPHH3N8RiMxNa13F@redhat.com \
--to=kwolf@redhat.com \
--cc=fam@euphon.net \
--cc=frolov@swemel.ru \
--cc=hreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sdl.qemu@linuxtesting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).