From: "Daniel P. Berrangé" <berrange@redhat.com>
To: William Tsai <williamtsai1111@gmail.com>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Hanna Reitz <hreitz@redhat.com>, Eric Blake <eblake@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
Peter Lieven <pl@kamp.de>, Fam Zheng <fam@euphon.net>,
"Richard W.M. Jones" <rjones@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Michael Roth <michael.roth@amd.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Eduardo Habkost <eduardo@habkost.net>,
Richard Henderson <richard.henderson@linaro.org>,
David Hildenbrand <david@redhat.com>,
Ilya Leoshkevich <iii@linux.ibm.com>,
Thomas Huth <thuth@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Laurent Vivier <lvivier@redhat.com>,
"open list:Block layer core" <qemu-block@nongnu.org>,
"open list:S390 TCG CPUs" <qemu-s390x@nongnu.org>,
"open list:ARM TCG CPUs" <qemu-arm@nongnu.org>
Subject: Re: [PATCH v2] qdict: Preserve order for iterating qdict elements
Date: Mon, 4 Sep 2023 17:38:29 +0100 [thread overview]
Message-ID: <ZPYIBVtUgDGhj3TQ@redhat.com> (raw)
In-Reply-To: <20230902094041.8626-1-williamtsai1111@gmail.com>
On Sat, Sep 02, 2023 at 05:40:40PM +0800, William Tsai wrote:
> Changing the structure of qdict so that it can preserve order when
> iterating qdict. This will fix array_properties as it relies on `len-`
> prefixed argument to be set first.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1090
> Signed-off-by: William Tsai <williamtsai1111@gmail.com>
This is a variation of what Markus illustrated a year ago
https://lists.gnu.org/archive/html/qemu-devel/2022-07/msg00758.html
I wasn't a particular fan of that approach at the time.
I've made an alternative proposal here which avoids the broader
impact of this QDict change:
https://lists.gnu.org/archive/html/qemu-devel/2023-09/msg00652.html
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-09-04 16:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-02 9:40 [PATCH v2] qdict: Preserve order for iterating qdict elements William Tsai
2023-09-04 16:38 ` Daniel P. Berrangé [this message]
2023-09-06 10:25 ` David Hildenbrand
2023-09-06 12:21 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPYIBVtUgDGhj3TQ@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=david@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=iii@linux.ibm.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pl@kamp.de \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rjones@redhat.com \
--cc=thuth@redhat.com \
--cc=vsementsov@yandex-team.ru \
--cc=williamtsai1111@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).